-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of submodule.fetchJobs and fetch.parallel #1569
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
#!/bin/bash | ||
|
||
if [ ! -f "./submodules-recursive/regular-file.txt" ]; then | ||
echo "Expected regular file does not exist" | ||
exit 1 | ||
fi | ||
|
||
if [ ! -f "./submodules-recursive/submodule-level-1/submodule-file.txt" ]; then | ||
echo "Expected submodule file does not exist" | ||
exit 1 | ||
fi | ||
|
||
if [ ! -f "./submodules-recursive/submodule-level-1/submodule-level-2/nested-submodule-file.txt" ]; then | ||
echo "Expected nested submodule file does not exists" | ||
exit 1 | ||
fi | ||
|
||
echo "Testing fetchJobs exists" | ||
git config --local --get-regexp submodules.fetchJobs | grep 10 | ||
if [ "$?" != "0" ]; then | ||
echo "Failed to validate fetchJobs configuration" | ||
exit 1 | ||
fi | ||
|
||
echo "Testing persisted credential" | ||
pushd ./submodules-recursive/submodule-level-1/submodule-level-2 | ||
git config --local --name-only --get-regexp http.+extraheader && git fetch | ||
if [ "$?" != "0" ]; then | ||
echo "Failed to validate persisted credential" | ||
popd | ||
exit 1 | ||
fi | ||
popd |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,100 +1,109 @@ | ||
name: 'Checkout' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know why this shows this big diff, I thought it could be formatting but it doesnt seem like it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you want to see the reason, I would suggest to run |
||
description: 'Checkout a Git repository at a particular version' | ||
inputs: | ||
repository: | ||
description: 'Repository name with owner. For example, actions/checkout' | ||
default: ${{ github.repository }} | ||
ref: | ||
description: > | ||
The branch, tag or SHA to checkout. When checking out the repository that | ||
triggered a workflow, this defaults to the reference or SHA for that | ||
event. Otherwise, uses the default branch. | ||
token: | ||
description: > | ||
Personal access token (PAT) used to fetch the repository. The PAT is configured | ||
with the local git config, which enables your scripts to run authenticated git | ||
commands. The post-job step removes the PAT. | ||
We recommend using a service account with the least permissions necessary. | ||
Also when generating a new PAT, select the least scopes necessary. | ||
[Learn more about creating and using encrypted secrets](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets) | ||
default: ${{ github.token }} | ||
ssh-key: | ||
description: > | ||
SSH key used to fetch the repository. The SSH key is configured with the local | ||
git config, which enables your scripts to run authenticated git commands. | ||
The post-job step removes the SSH key. | ||
We recommend using a service account with the least permissions necessary. | ||
[Learn more about creating and using | ||
encrypted secrets](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets) | ||
ssh-known-hosts: | ||
description: > | ||
Known hosts in addition to the user and global host key database. The public | ||
SSH keys for a host may be obtained using the utility `ssh-keyscan`. For example, | ||
`ssh-keyscan github.com`. The public key for github.com is always implicitly added. | ||
ssh-strict: | ||
description: > | ||
Whether to perform strict host key checking. When true, adds the options `StrictHostKeyChecking=yes` | ||
and `CheckHostIP=no` to the SSH command line. Use the input `ssh-known-hosts` to | ||
configure additional hosts. | ||
default: true | ||
persist-credentials: | ||
description: 'Whether to configure the token or SSH key with the local git config' | ||
default: true | ||
path: | ||
description: 'Relative path under $GITHUB_WORKSPACE to place the repository' | ||
clean: | ||
description: 'Whether to execute `git clean -ffdx && git reset --hard HEAD` before fetching' | ||
default: true | ||
filter: | ||
description: > | ||
Partially clone against a given filter. | ||
Overrides sparse-checkout if set. | ||
default: null | ||
sparse-checkout: | ||
description: > | ||
Do a sparse checkout on given patterns. | ||
Each pattern should be separated with new lines. | ||
default: null | ||
sparse-checkout-cone-mode: | ||
description: > | ||
Specifies whether to use cone-mode when doing a sparse checkout. | ||
default: true | ||
fetch-depth: | ||
description: 'Number of commits to fetch. 0 indicates all history for all branches and tags.' | ||
default: 1 | ||
fetch-tags: | ||
description: 'Whether to fetch tags, even if fetch-depth > 0.' | ||
default: false | ||
show-progress: | ||
description: 'Whether to show progress status output when fetching.' | ||
default: true | ||
lfs: | ||
description: 'Whether to download Git-LFS files' | ||
default: false | ||
submodules: | ||
description: > | ||
Whether to checkout submodules: `true` to checkout submodules or `recursive` to | ||
recursively checkout submodules. | ||
When the `ssh-key` input is not provided, SSH URLs beginning with `[email protected]:` are | ||
converted to HTTPS. | ||
default: false | ||
set-safe-directory: | ||
description: Add repository path as safe.directory for Git global config by running `git config --global --add safe.directory <path>` | ||
default: true | ||
github-server-url: | ||
description: The base URL for the GitHub instance that you are trying to clone from, will use environment defaults to fetch from the same instance that the workflow is running from unless specified. Example URLs are https://github.com or https://my-ghes-server.example.com | ||
required: false | ||
runs: | ||
using: node20 | ||
main: dist/index.js | ||
post: dist/index.js | ||
name: 'Checkout' | ||
description: 'Checkout a Git repository at a particular version' | ||
inputs: | ||
repository: | ||
description: 'Repository name with owner. For example, actions/checkout' | ||
default: ${{ github.repository }} | ||
ref: | ||
description: > | ||
The branch, tag or SHA to checkout. When checking out the repository that | ||
triggered a workflow, this defaults to the reference or SHA for that | ||
event. Otherwise, uses the default branch. | ||
token: | ||
description: > | ||
Personal access token (PAT) used to fetch the repository. The PAT is configured | ||
with the local git config, which enables your scripts to run authenticated git | ||
commands. The post-job step removes the PAT. | ||
We recommend using a service account with the least permissions necessary. | ||
Also when generating a new PAT, select the least scopes necessary. | ||
[Learn more about creating and using encrypted secrets](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets) | ||
default: ${{ github.token }} | ||
ssh-key: | ||
description: > | ||
SSH key used to fetch the repository. The SSH key is configured with the local | ||
git config, which enables your scripts to run authenticated git commands. | ||
The post-job step removes the SSH key. | ||
We recommend using a service account with the least permissions necessary. | ||
[Learn more about creating and using | ||
encrypted secrets](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets) | ||
ssh-known-hosts: | ||
description: > | ||
Known hosts in addition to the user and global host key database. The public | ||
SSH keys for a host may be obtained using the utility `ssh-keyscan`. For example, | ||
`ssh-keyscan github.com`. The public key for github.com is always implicitly added. | ||
ssh-strict: | ||
description: > | ||
Whether to perform strict host key checking. When true, adds the options `StrictHostKeyChecking=yes` | ||
and `CheckHostIP=no` to the SSH command line. Use the input `ssh-known-hosts` to | ||
configure additional hosts. | ||
default: true | ||
persist-credentials: | ||
description: 'Whether to configure the token or SSH key with the local git config' | ||
default: true | ||
path: | ||
description: 'Relative path under $GITHUB_WORKSPACE to place the repository' | ||
clean: | ||
description: 'Whether to execute `git clean -ffdx && git reset --hard HEAD` before fetching' | ||
default: true | ||
filter: | ||
description: > | ||
Partially clone against a given filter. | ||
Overrides sparse-checkout if set. | ||
default: null | ||
sparse-checkout: | ||
description: > | ||
Do a sparse checkout on given patterns. | ||
Each pattern should be separated with new lines. | ||
default: null | ||
sparse-checkout-cone-mode: | ||
description: > | ||
Specifies whether to use cone-mode when doing a sparse checkout. | ||
default: true | ||
fetch-depth: | ||
description: 'Number of commits to fetch. 0 indicates all history for all branches and tags.' | ||
default: 1 | ||
fetch-tags: | ||
description: 'Whether to fetch tags, even if fetch-depth > 0.' | ||
default: false | ||
fetch-parallel: | ||
description: > | ||
Specifies the maximal number of fetch operations to be run in parallel at a time (submodules, or remotes when the --multiple option of git-fetch is in effect). | ||
A value of 0 will give some reasonable default. If unset, it defaults to 1. | ||
default: 1 | ||
show-progress: | ||
description: 'Whether to show progress status output when fetching.' | ||
default: true | ||
lfs: | ||
description: 'Whether to download Git-LFS files' | ||
default: false | ||
submodules: | ||
description: > | ||
Whether to checkout submodules: `true` to checkout submodules or `recursive` to | ||
recursively checkout submodules. | ||
When the `ssh-key` input is not provided, SSH URLs beginning with `[email protected]:` are | ||
converted to HTTPS. | ||
default: false | ||
submodules-fetch-jobs: | ||
description: > | ||
Specifies how many submodules are fetched/cloned at the same time. A positive integer allows up to that number of submodules fetched in parallel. A value of 0 will give some reasonable default. If unset, it defaults to 1. | ||
default: 1 | ||
set-safe-directory: | ||
description: Add repository path as safe.directory for Git global config by running `git config --global --add safe.directory <path>` | ||
default: true | ||
github-server-url: | ||
description: The base URL for the GitHub instance that you are trying to clone from, will use environment defaults to fetch from the same instance that the workflow is running from unless specified. Example URLs are https://github.com or https://my-ghes-server.example.com | ||
required: false | ||
runs: | ||
using: node20 | ||
main: dist/index.js | ||
post: dist/index.js |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,6 +153,7 @@ export async function getSource(settings: IGitSourceSettings): Promise<void> { | |
|
||
// Fetch | ||
core.startGroup('Fetching the repository') | ||
await git.config('fetch.parallel', settings.fetchParallel.toString(), true) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this the right place to set it? |
||
const fetchOptions: { | ||
filter?: string | ||
fetchDepth?: number | ||
|
@@ -232,6 +233,11 @@ export async function getSource(settings: IGitSourceSettings): Promise<void> { | |
|
||
// Checkout submodules | ||
core.startGroup('Fetching submodules') | ||
await git.config( | ||
'submodule.fetchJobs', | ||
settings.submodulesFetchJobs.toString(), | ||
true | ||
) | ||
await git.submoduleSync(settings.nestedSubmodules) | ||
await git.submoduleUpdate(settings.fetchDepth, settings.nestedSubmodules) | ||
await git.submoduleForeach( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right way to test this?