-
Notifications
You must be signed in to change notification settings - Fork 648
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into feature/png_compression
- Loading branch information
Showing
53 changed files
with
3,293 additions
and
2,386 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[flake8] | ||
max-line-length = 88 | ||
extend-ignore = E203, W503 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: "[BUG]" | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## 🐛🐛 Bug Report | ||
|
||
|
||
### ⚗️ Current Behavior | ||
A clear and concise description of the behavior. | ||
|
||
**Input Code** | ||
- REPL or Repo link if applicable: | ||
|
||
```python | ||
def function_wrong(): | ||
pass | ||
``` | ||
|
||
**Expected behavior/code** | ||
A clear and concise description of what you expected to happen (or code). | ||
|
||
```python | ||
def function_right(): | ||
# Here is the fix | ||
print("Ok) | ||
|
||
``` | ||
|
||
### ⚙️ Environment | ||
|
||
- `Python` version(s): | ||
- *good*: [e.g. 3.8] | ||
- **better**: [3.8.6 - Clang 12.0.0 (clang-1200.0.32.27)] | ||
- `OS`: [e.g. Ubuntu 18.04, OSX 10.13.4, Windows 10] | ||
- `IDE`: [Vim, VS-Code, Pycharme] | ||
- `Packages`: [ `Tensorflow==2.1.2 - latest`] | ||
|
||
|
||
### 🧰 Possible Solution (optional) | ||
<!--- Only if you have suggestions on a fix for the bug --> | ||
|
||
### 🖼 Additional context/Screenshots (optional) | ||
Add any other context about the problem here. If applicable, add screenshots to help explain. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: "[FEATURE]" | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
## 🚨🚨 Feature Request | ||
|
||
- [ ] Related to an existing [Issue](../../../issues) | ||
- [ ] A new implementation (Improvement, Extension) | ||
|
||
### Is your feature request related to a problem? | ||
|
||
A clear and concise description of what the problem is. Ex. I have an issue when [...] | ||
|
||
### If your feature will improve `HUB` | ||
|
||
A clear and concise description of how it will help `HUB`. Please prefer references, if possible [...] | ||
|
||
|
||
### Description of the possible solution | ||
|
||
A clear and concise description of what you want to happen. Add any considered drawbacks. | ||
|
||
### An alternative solution to the problem can look like | ||
|
||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Teachability, Documentation, Adoption, Migration Strategy** | ||
If you can, explain how users will be able to use this and possibly write out a version the docs. | ||
Maybe a screenshot or design? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## 🚀 🚀 Pull Request | ||
|
||
### All Submissions: | ||
|
||
- [ ] Have you followed the guidelines in our Contributing document? | ||
- [ ] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change? | ||
- [ ] Is your [Pull Requests](../../../pulls) linked to an [Issue](../../../issues) | ||
|
||
|
||
|
||
### New Feature Submissions: | ||
|
||
- [ ] Does your submission pass all `tests`? | ||
- [ ] Does your submission not lower the `coverage-rate`? | ||
- [ ] Have you lint your code locally prior to submission; including `black` style? | ||
- [ ] Have you describe your new feature in the `docs`? | ||
|
||
|
||
### Changes to Core Features: | ||
|
||
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them? | ||
- [ ] Have you written new `tests` for your core changes, as applicable? | ||
- [ ] Have you successfully ran `tests` with your changes locally? | ||
- [ ] Have you keep the `coverage-rate` constant? | ||
- [ ] Have you keep the `coverage-rate` up? | ||
- [ ] Are the `docs` up to date? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,42 @@ To contribute a feature/fix: | |
* Add a feature. For an extended feature please create an issue to discuss. | ||
|
||
|
||
## Get Started | ||
|
||
Ready to contribute? Here's how to set up `Hub` for local development. | ||
|
||
1. Fork the `Hub` repo on GitHub. | ||
2. Clone your fork locally: | ||
``` | ||
$ git clone [email protected]:your_name_here/hub.git | ||
``` | ||
3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, | ||
this is how you set up your fork for local development: | ||
``` | ||
$ mkvirtualenv Hub | ||
$ cd Hub/ | ||
``` | ||
4. Create a branch for local development: | ||
``` | ||
$ git checkout -b name-of-your-bugfix-or-feature | ||
``` | ||
Now you can make your changes locally. | ||
|
||
5. While hacking your changes, make sure to cover all your developments with the required | ||
unit tests, and that none of the old tests fail as a consequence of your changes. | ||
For this, make sure to run the tests suite and check the code coverage:: | ||
``` | ||
$ pytest . # Run the tests | ||
``` | ||
6. Commit your changes and push your branch to GitHub:: | ||
``` | ||
$ git add . | ||
$ git commit -m "Your detailed description of your changes." | ||
$ git push origin name-of-your-bugfix-or-feature | ||
``` | ||
7. Submit a pull request through the GitHub website. | ||
|
||
|
||
## Formatting and Linting | ||
Hub uses Black and Flake8 to ensure a consistent code format throughout the project. | ||
if you are using vscode then Replace `.vscode/settings.json` content with the following: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.