feat: vectorized implementation of the cross poduct #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
force-pushed
the
feat-optimize-vectorization
branch
from
e35c809 to
586b28f
Compare
niermann999
force-pushed
the
feat-optimize-vectorization
branch
2 times, most recently
from
b9cf02d to
53a78ec
Compare
niermann999
force-pushed
the
feat-optimize-vectorization
branch
2 times, most recently
from
d1c727c to
f877287
Compare
niermann999
force-pushed
the
feat-optimize-vectorization
branch
2 times, most recently
from
be68160 to
ce4417f
Compare
… the Vc AoS plugin. Since there is a trailing zero element to reach a fixed alignment, this has to be initialized to a specific value from the input vectors, so that the shuffles result in the correct vectors to do the multiplication and subtraction with.
niermann999
force-pushed
the
feat-optimize-vectorization
branch
from
ce4417f to
64cfdd7
Compare
|
stephenswat
reviewed
Mar 18, 2025
stephenswat
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shuffle operations for the implementation of the cross product in the Vc AoS plugin. Since there is a trailing zero element to reach a fixed alignment, this has to be initialized to a specific value from the input vectors, so that the shuffles result in the correct vectors to do the multiplication and subtraction with.
Edit: For some reason the shuffles don't compile into something efficient on avx registers, so I kept the old fma approach for double precision