Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update externals #157

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

niermann999
Copy link
Contributor

Update Fastor to version 0.6.4
Update google test to version 1.16.0
Update Vc to version 1.4.5
Update vecmem to version 1.14.0

@niermann999 niermann999 added the enhancement New feature or request label Mar 17, 2025
@niermann999 niermann999 requested a review from krasznaa March 18, 2025 12:17
@niermann999
Copy link
Contributor Author

I get some very different results in the benchmarks now, I need to have another look

@niermann999 niermann999 marked this pull request as draft March 18, 2025 15:38
Update google test to version 1.16.0
Update Vc to version 1.4.5
Update vecmem to version 1.14.0
@niermann999
Copy link
Contributor Author

I think the changes in the reported benchmark timings come from this issue google/benchmark#1834 with this fix google/benchmark#1836, since dividing the new reported time by the number of threads gives roughly the old reported time

@niermann999 niermann999 marked this pull request as ready for review March 19, 2025 13:32
@niermann999 niermann999 requested a review from stephenswat March 19, 2025 13:42
@niermann999 niermann999 merged commit 69fad13 into acts-project:main Mar 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants