Add mocking-based unit tests for the stop command
#68
Conversation
uploaded pycharm file
createt automated testing
create new folder commands and set up the file for testing the command file stop
…lever/commands/test_status_execute_mocken.py changing the path of the test_status_execute_mocken file
1. Add a test for the first part of the execute function 2. More detailed description in the comments
Fixing some pep8 warnings, shortening the code and making it more precise.
Made the code shorter
Linelenght to 79
Linelenght to 79
|
|
||
| def test_should_have_qleverfile(self): | ||
| result = StopCommand().should_have_qleverfile() | ||
| assert result |
There was a problem hiding this comment.
There is some self.assertTrue(StopCommand().should_have_qleverfile()) opportunity here
(one line less + more important always use the same assertion mechanims consistently.
| # Parse an empty argument list to see the default | ||
| args = parser.parse_args([]) | ||
|
|
||
| # Test that the default value for cmdline_regex is set correctly | ||
| self.assertEqual(args.cmdline_regex, "ServerMain.* -i " | ||
| "[^ ]*%%NAME%%") | ||
|
|
||
| # Test that the help text for cmdline_regex is correctly set | ||
| argument_help = subparser._group_actions[-2].help | ||
| self.assertEqual(argument_help, "Show only processes where " | ||
| "the command line matches this regex") | ||
|
|
||
| # Test that the default value for no-containers is set correctly | ||
| self.assertEqual(args.no_containers, False) | ||
|
|
||
| # Test that the help text for no-containers is correctly set | ||
| argument_help = subparser._group_actions[-1].help | ||
| self.assertEqual(argument_help, "Do not look for containers, " | ||
| "only for native processes") |
There was a problem hiding this comment.
Wouldn't it be simpler to also mock the ArgumentParser for the testing of the add_argument_group.
Otherwise you could use implement some abstraction, that does the assertions on the actual ArgParse object, but abstracts away all the stuff with the _group_actions[-1] etc.
But maybe I am overthinking.
test/qlever/test_stop_execute.py
Outdated
| # Setup args | ||
| args = MagicMock() | ||
| args.cmdline_regex = "ServerMain.* -i [^ ]*%%NAME%%" | ||
| args.name = "TestName" | ||
| args.no_containers = True |
There was a problem hiding this comment.
I think (for this whole file) we agreed to split up the execute function, to make it easier testable
(separate functions for long if or try statements etc.
I am sure, if you do this , you can simplify the tests (first change the implementations, tests should still work, then simplify the tests).
change tests because of changes in stop.py
joka921
changed the title
stop command
No description provided.