Accept access token from Authorization header
#1720
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 393 393
Lines 37479 37512 +33
Branches 4221 4227 +6
==========================================
+ Hits 33694 33730 +36
+ Misses 2482 2480 -2
+ Partials 1303 1302 -1 ☔ View full report in Codecov by Sentry. |
|
Note: The suggestions is to use a raw string literal for a string with 3 |
Conformance check passed ✅No test result changes. |
|
| tokenFromAuthorizationHeader != tokenFromParameter) { | ||
| throw std::runtime_error( | ||
| "Access token is specified both in the `Authorization` Header and the " | ||
| "parameters, but they aren't the same."); |
There was a problem hiding this comment.
The first part is gread, maybe make the second part "and the access-token parameter, then really everybody knows how to fix this.
| @@ -1128,8 +1140,7 @@ bool Server::checkAccessToken( | |||
| if (!accessToken) { | |||
| return false; | |||
| } | |||
| auto accessTokenProvidedMsg = absl::StrCat( | |||
| "Access token \"access-token=", accessToken.value(), "\" provided"); | |||
| auto accessTokenProvidedMsg = absl::StrCat("Access token was provided"); | |||
There was a problem hiding this comment.
The StrCat is absolutely redundant and should be removedd.
The access token could previously only be passed as a parameter (field in the data for
application/x-www-form-urlencodedand query parameter otherwise). With this PR the access token is also read from the Authorization header in the formatBearer <access token>. TheAuthorizationheader (if present) takes precedence over the parameter.Resolves #1691