Version 1.16.0: ada 3.0.1

[bbayles]

This PR upgrades to the latest version of ada, 3.0.0.

[TkTech]

I went through this same process yesterday, debugging actions kinda sucks. Have you seen https://github.com/nektos/act?

[bbayles]

@jameshilliard - you were very helpful on debugging the cibuildwheel piece before. Do you know how to make it use g++12 properly when building on Linux? Usually I have the most trouble with Windows, but today it's Linux.

[anonrig]

Have you tried actually installing gcc-12 using sudo apt install gcc-12?

[jameshilliard]

Do you know how to make it use g++12 properly when building on Linux?

Hmm, pretty sure the CXX env variable controls which c++ compiler is used by setuptools.

[anonrig]

Do you know how to make it use g++12 properly when building on Linux?

Hmm, pretty sure the CXX env variable controls which c++ compiler is used by setuptools.

Yes but if gcc-12 is not installed then g++-12 will not be available.

[anonrig]

Actually the error message agrees with me

error: command 'g++-12' failed: No such file or directory

[jameshilliard]

Yes but if gcc-12 is not installed then g++-12 will not be available.

Install it using github actions then?

[bbayles]

Tried installing it here...

[jameshilliard]

Hmm, might be a cibuildwheel limitation:

manylinux2010 and manylinux2014 are newer and support all C++ standards (up to C++17).

[bbayles]

More on that theory: pypa/cibuildwheel#984 (reply in thread)

[TkTech]

Debugging on a phone so bear with me - This isn't quite doing anything. The manylinux wheels build inside a container cibuildwheel sets up, and so anything you install on the host like this won't do anything. There's a CIBW_ envvar to provide commands to run inside the container before they run

[TkTech]

https://cibuildwheel.pypa.io/en/stable/options/#before-build

[anonrig]

FYI, I just released v3.0.1 with a fix addressing a LLVM bug.

[jameshilliard]

More on that theory: pypa/cibuildwheel#984 (reply in thread)

Hmm, it's implied here that manylinux_2_28 builders should give you GCC 13, if that's the case then installing GCC 12 via apt-get shouldn't be necessary.

[bbayles]

This run shows it at least attempting to use g++-12, though it then says it wasn't installed. The latest one fails because apt isn't there, so I guess we're getting a CentOS build?

Also getting a test failure on Mac with 3.0.1, but one thing at a time...

[jameshilliard]

This run shows it at least attempting to use g++-12, though it then says it wasn't installed.

I'm thinking that only installed g++-12 on the base system and not the actual cibuildwheel container doing the build. I'd say try removing all the g++-12 specific stuff and just try using the default g++.

[jameshilliard]

So x86_64 now seems to be building fine, aarch64 is broken though.

Looks like you probably need to add:

manylinux-aarch64-image = "manylinux_2_28"

[bbayles]

Many thanks for the assistance. The Linux issues are now solved: the key was changing manylinux versions; all else was a distraction.

The Mac issue is also solved: I set MACOSX_DEPLOYMENT_TARGET during testing.