Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on the main branch #89

Merged
merged 16 commits into from
Jun 24, 2024
Merged

Fix building on the main branch #89

merged 16 commits into from
Jun 24, 2024

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Jun 20, 2024

An update to the MacOS GitHub Actions image seems to have broken the build process on the main branch. This PR updates certifi to (hopefully?) fix it.

@bbayles
Copy link
Collaborator Author

bbayles commented Jun 20, 2024

That didn't work, nor did unpinning the dependencies that brew installs. Also, something's changed with the Ubuntu image now, too.

I'll try something else...

@anonrig
Copy link
Member

anonrig commented Jun 20, 2024

Can we somehow simplify our build process, and reduce the dependency count?

@bbayles
Copy link
Collaborator Author

bbayles commented Jun 20, 2024

Almost everything comes in via Sphinx, which is used to build docs.

@bbayles bbayles changed the title Update certifi Fix building on the main branch Jun 21, 2024
@bbayles
Copy link
Collaborator Author

bbayles commented Jun 24, 2024

Now fixed. Changes:

  • Use the latest Ubuntu and MacOS runners
  • Migrate fully to pyproject.toml from setup.cfg for configuration
  • Drop the .o file from the source distribution

@bbayles bbayles merged commit f7eaf87 into main Jun 24, 2024
8 checks passed
@bbayles bbayles deleted the update-certifi-requirement branch June 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants