Merge branch 'main' into yagiz/add-url-pattern

.bazelignore

@@ -0,0 +1,4 @@
+build
+cmake-build-debug-coverage
+cmake-build-debug
+cmake-build-release

.bazelrc

@@ -0,0 +1 @@
+build --cxxopt="-std=c++20"

.bazelversion

@@ -0,0 +1 @@
+8.0.0

.github/workflows/bazel.yml

@@ -0,0 +1,54 @@
+name: Bazel
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - '**.md'
+      - 'docs/**'
+
+permissions:
+  contents: read
+  actions: write
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  macos:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: bazel-contrib/setup-bazel@bbf8fe8b219f642c7f8bc673215f28eb1d9dec51 # v0.10.0
+        with:
+          bazelisk-cache: true
+          disk-cache: ${{ github.workflow }}
+          repository-cache: true
+      - name: Build & Test
+        run: bazel test //...
+  ubuntu:
+    strategy:
+      fail-fast: false
+      matrix:
+        shared: [ON, OFF]
+        cxx: [g++-12, clang++-14]
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: bazel-contrib/setup-bazel@bbf8fe8b219f642c7f8bc673215f28eb1d9dec51 # v0.10.0
+        with:
+          bazelisk-cache: true
+          disk-cache: ${{ github.workflow }}
+          repository-cache: true
+      - name: Build & Test
+        run: bazel test //...
+        env:
+          CC: ${{matrix.cxx}}
+          CXX: ${{matrix.cxx}}

.gitignore

@@ -25,4 +25,7 @@ benchmarks/competitors/servo-url/target
 
 #ignore VScode
 .vscode/
-.idea
+.idea
+
+# bazel output
+bazel-*

BUILD.bazel

@@ -0,0 +1,20 @@
+cc_library(
+    name = "ada",
+    srcs = [
+        "src/ada.cpp",
+    ],
+    hdrs = glob([
+        "include/*.h",
+        "include/ada/*.h",
+        # todo: this can be included by every client of the library, but there is no better way
+        # since .cpp files are included into each other.
+        "src/*.cpp",
+    ]),
+    # todo: once .cpp files are not included, rather then polluting -I flags, src/ should
+    # be dropped from hdrs and this replaced by `strip_include_prefix = "include"`
+    includes = [
+        "include",
+        "include/ada",
+    ],
+    visibility = ["//visibility:public"],
+)

MODULE.bazel

@@ -0,0 +1 @@
+bazel_dep(name = "googletest", version = "1.15.2")

README.md

@@ -315,7 +315,13 @@ You can install Ada using `brew install ada-url`.
 
 Ada uses cmake as a build system. It's recommended you to run the following commands to build it locally.
 
+Without tests:
+
 - **Build**: `cmake -B build && cmake --build build`
+
+With tests (requires git):
+
+- **Build**: `cmake -B build -DADA_TESTING=ON && cmake --build build`
 - **Test**: `ctest --output-on-failure --test-dir build`
 
 Windows users need additional flags to specify the build configuration, e.g. `--config Release`.

include/ada/checkers-inl.h

@@ -13,8 +13,7 @@ namespace ada::checkers {
 constexpr bool has_hex_prefix_unsafe(std::string_view input) {
   // This is actually efficient code, see has_hex_prefix for the assembly.
   constexpr bool is_little_endian = std::endian::native == std::endian::little;
-  constexpr auto word0x =
-      std::bit_cast<uint16_t>(static_cast<uint16_t>(0x7830));
+  constexpr uint16_t word0x = 0x7830;
   uint16_t two_first_bytes =
       static_cast<uint16_t>(input[0]) |
       static_cast<uint16_t>((static_cast<uint16_t>(input[1]) << 8));

tests/BUILD.bazel

@@ -0,0 +1,9 @@
+cc_test(
+    name = "url_search_params",
+    srcs = ["url_search_params.cpp"],
+    deps = [
+        "//:ada",
+        "@googletest//:gtest",
+        "@googletest//:gtest_main",
+    ],
+)