Skip to content

Commit

Permalink
Fix a regression due to llvm bug (#859)
Browse files Browse the repository at this point in the history
* add more macos versions to test

* revert private due to llvm bug
  • Loading branch information
anonrig authored Jan 30, 2025
1 parent d44402b commit c1df595
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/macos_install.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: macos (Installation)
name: macOS (Installation)

on:
pull_request:
Expand All @@ -22,11 +22,11 @@ concurrency:

jobs:
macos-build:
runs-on: macos-15
strategy:
matrix:
include:
- shared: OFF
shared: [OFF]
runs-on: [macos-13, macos-14, macos-15]
runs-on: ${{matrix.runs-on}}
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Prepare
Expand Down
46 changes: 45 additions & 1 deletion include/ada/url_pattern.h
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,59 @@ class url_pattern {
std::variant<std::string_view, url_pattern_init> input,
const std::string_view* base_url, const url_pattern_options* options);

private:
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> protocol_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> username_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> password_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> hostname_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> port_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> pathname_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> search_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
url_pattern_component<regex_provider> hash_component{};
/**
* @private
* We can not make this private due to a LLVM bug.
* Ref: https://github.com/ada-url/ada/pull/859
*/
bool ignore_case_ = false;
};

Expand Down

0 comments on commit c1df595

Please sign in to comment.