Small changes #780
Merged
Small changes #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/small-fixes
branch
from
fa82cbb to
a4e2ed3
Compare
lemire
reviewed
Nov 18, 2024
| input.begin(), std::ranges::find_if(input, [character_set](const char c) { | ||
| return character_sets::bit_at(character_set, c); | ||
| })); | ||
| const char* data = input.data(); |
There was a problem hiding this comment.
I am not opposed to this change, @anonrig, but did you determine that it was worth doing? This seems significantly more complicated than what we had. It is fine if it is worth it...
There was a problem hiding this comment.
It is not noticable due to the complexity of Ada, but the instruction count should have been lower with the new implementation. Do you see different/worse results?
There was a problem hiding this comment.
Ok. I am not going to check. I expect that it will save instructions especially on long inputs (say a 2x saving) and hopefully make things a bit faster.
lemire
reviewed
Nov 18, 2024
Co-authored-by: Daniel Lemire <[email protected]>
lemire
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes.