Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think that the test is in error #810

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Dec 23, 2024

You have

if (parse_result.has_value()) {

where you need to have something like

if (parse_result.value().has_value()) {

@lemire lemire requested a review from anonrig December 23, 2024 22:51
@anonrig anonrig merged commit 8586b04 into yagiz/add-url-pattern Dec 23, 2024
8 of 25 checks passed
@anonrig anonrig deleted the yagiz/add-url-pattern-more-fixes branch December 23, 2024 23:00
anonrig pushed a commit that referenced this pull request Jan 8, 2025
anonrig pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants