Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web platform tests #835

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update web platform tests #835

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 9, 2025

This is an automated pull request for updating the WPT.

cc @anonrig @lemire

@anonrig anonrig requested a review from a team January 9, 2025 00:06
jasnell
jasnell approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp LGTM although it looks like there are some CI failures to address

@anonrig
Copy link
Member Author

anonrig commented Jan 9, 2025

rubber stamp LGTM although it looks like there are some CI failures to address

These are the invalid test cases in WPT.

@anonrig anonrig requested a review from a team January 10, 2025 00:06
@anonrig anonrig force-pushed the automatic-update-wpt branch 2 times, most recently from cfbc3d1 to 82e0e74 Compare January 13, 2025 00:07
@lemire
Copy link
Member

lemire commented Jan 13, 2025

@anonrig

These are the invalid test cases in WPT.

That's a problem for this PR, isn't it?

@anonrig
Copy link
Member Author

anonrig commented Jan 13, 2025

@anonrig

These are the invalid test cases in WPT.

That's a problem for this PR, isn't it?

Yes, we shouldn't the invalid ones. Some are obvious some are not.

@lemire
Copy link
Member

lemire commented Jan 15, 2025

@anonrig Please see #841

@anonrig anonrig marked this pull request as draft January 17, 2025 03:13
@anonrig anonrig force-pushed the automatic-update-wpt branch 4 times, most recently from d3857c9 to b0a7e01 Compare January 24, 2025 00:06
@anonrig anonrig force-pushed the automatic-update-wpt branch 4 times, most recently from cb0fed0 to b35e27f Compare January 30, 2025 00:06
@anonrig anonrig force-pushed the automatic-update-wpt branch from b35e27f to 5e0e73b Compare January 31, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @lemire @jasnell