Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoiding macro clash #854

Merged
merged 2 commits into from
Jan 29, 2025
Merged

avoiding macro clash #854

merged 2 commits into from
Jan 29, 2025

Conversation

lemire
Copy link
Member

@lemire lemire commented Jan 29, 2025

Some all-case common words can be set by build systems, especially under Windows. For example, the symbol STRICT has a special meaning: https://learn.microsoft.com/en-us/windows/win32/winprog/enabling-strict

Should help get nodejs/node#56452 building under Windows in Node.

@anonrig anonrig merged commit ff92faa into main Jan 29, 2025
41 checks passed
@anonrig anonrig deleted the windows_macro branch January 29, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants