Fix https://github.com/adafruit/Adafruit_CircuitPython_GPS/issues/105 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes parsing for RMC messages to that time values are still reported even if there is not a GPS fix. This is particularly relevant for GPS cards which have a battery included and maintain an RTC clock onboard, eg: the adafruit Ultimate GPS v3.
Note there is a logical change in _parse_rmc which means lat/lon values won't be returned when there's no fix. Prior version could conceivably have allowed this, but I believe that lat/lon/speed values are never provided without a fix in practice.