Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: initialise Argo CD app of apps documentation #427

Merged
merged 3 commits into from
Nov 10, 2021
Merged

docs: initialise Argo CD app of apps documentation #427

merged 3 commits into from
Nov 10, 2021

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Nov 8, 2021

Description

This is the first part of the overarching changeset needed to properly document our -apps suffixed Argo CD app-of-apps charts as requested in #84.

  • Splits Argo CD app-of-apps charts into their own main README section (demo)
  • Adds initial docs/argocd-app-of-apps.md file (demo)
  • cleanup README to make all tables look nice when view through github (demo)

After merging this, the docs/argocd-app-of-apps.md file can be collaboratively edited to adress the remaining tasks in #84, some of which will need further refinement before we are ready to document them.

Issues

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run -a
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2021
@hairmare hairmare marked this pull request as ready for review November 8, 2021 09:26
@hairmare hairmare requested a review from a team as a code owner November 8, 2021 09:26
@hairmare hairmare requested review from eyenx and vmaillot and removed request for a team November 8, 2021 09:26
@hairmare hairmare changed the title Docs/app of apps docs: initialise Argo CD app of apps documentation Nov 8, 2021
@hairmare hairmare requested review from paraenggu and removed request for eyenx November 8, 2021 10:14
@hairmare hairmare enabled auto-merge (squash) November 10, 2021 10:39
@hairmare hairmare merged commit 070ca66 into adfinis:master Nov 10, 2021
@hairmare hairmare deleted the docs/app-of-apps branch December 13, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants