Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app-of-apps): argoconfigs template #477

Merged
merged 7 commits into from
Dec 14, 2021
Merged

docs(app-of-apps): argoconfigs template #477

merged 7 commits into from
Dec 14, 2021

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Dec 13, 2021

Description

Add a section on the argoconfig lilbrary chart.

Issues

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2021
@hairmare hairmare marked this pull request as ready for review December 13, 2021 14:26
@hairmare hairmare requested a review from a team as a code owner December 13, 2021 14:26
@hairmare hairmare requested review from eyenx and tongpu and removed request for a team December 13, 2021 14:26
Copy link
Member

@tongpu tongpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to read the second part again tomorrow, but here are some minor recommendations from my side regarding how to lead over to code snippets. I would use :, but I'm actually not sure if the English language might be different from German in this regard.

docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
@hairmare
Copy link
Contributor Author

i don't like : before code examples (in neither language) but i'm not religious about it ;)

Copy link
Member

@tongpu tongpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still not at the point where we're able to really explain the concept in layman's terms, but I'm not sure if this is even possible.

docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
docs/argocd-app-of-apps.md Outdated Show resolved Hide resolved
@hairmare
Copy link
Contributor Author

I think we're still not at the point where we're able to really explain the concept in layman's terms, but I'm not sure if this is even possible.

This really only focuses on the library chart bits, #84 has some more tasks that should get us closer to explaning the big picture concept.

@hairmare hairmare enabled auto-merge (squash) December 14, 2021 14:50
@hairmare hairmare merged commit 91882df into adfinis:master Dec 14, 2021
@hairmare hairmare deleted the docs/app-of-apps/templates branch December 14, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants