Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (misc-apps) init misc-apps #79

Merged
merged 10 commits into from
Sep 9, 2020
Merged

✨ (misc-apps) init misc-apps #79

merged 10 commits into from
Sep 9, 2020

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Sep 2, 2020

Similar to #36 (infra-apps) but with things not needed on every cluster and maybe more experimental things as well.

Browse the chart here: https://github.com/hairmare/helm-charts/tree/feat/misc-apps/charts/misc-apps

@hairmare hairmare changed the title ✨ (misc-apps) init misc-app ✨ (misc-apps) init misc-apps Sep 2, 2020
Copy link
Contributor

@blaserd blaserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finlay I have looked over the entire chart, and added some comments and suggestions. I hope that at lest some of them are helpful.
All in all I am still not at all certain if I do have a sufficient understanding of this chart as of now for being able to sensibly approve merging it, but that might change if I get some feedback on my review and if I keep looking at some details afterwards.

charts/misc-apps/README.md Outdated Show resolved Hide resolved
charts/misc-apps/examples/signalilo.yaml Show resolved Hide resolved
charts/misc-apps/templates/downscaler.yaml Show resolved Hide resolved
charts/misc-apps/templates/signalilo.yaml Show resolved Hide resolved
charts/misc-apps/values.yaml Outdated Show resolved Hide resolved
charts/misc-apps/values.yaml Show resolved Hide resolved
charts/misc-apps/values.yaml Show resolved Hide resolved
charts/misc-apps/values.yaml Outdated Show resolved Hide resolved
charts/misc-apps/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@blaserd blaserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here come some more points that I noted only now. (Most actually only arose yesterday, I think.)
I hope these points are helpful.
I will now also try to deploy signalilo to my local test set-up. After that, and after addressing the newly noted points I guess that this PR could become ready for being merged form my point of view.

charts/misc-apps/README.md Outdated Show resolved Hide resolved
charts/misc-apps/templates/downscaler.yaml Outdated Show resolved Hide resolved
charts/misc-apps/templates/signalilo.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@blaserd blaserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some trials with the signalilo part I found one (small) issue there as well. Beside that I would say that, as to the extend that I understand it, the signalilo part does also look fine.

charts/misc-apps/examples/signalilo.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@blaserd blaserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this for quite some time now (and provided quite some feedback), and I would say that this now looks good to me.
At least up to the extent that I can judge this for now, which is of course not complete wisdom. However, getting an even deeper understanding and insight would take to much time, so I would opt for merging this now.

@hairmare hairmare merged commit ad80c87 into adfinis:master Sep 9, 2020
@hairmare hairmare deleted the feat/misc-apps branch September 9, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants