Skip to content

Implemented unit test to track the visualisation bug in #127. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

acataluddi
Copy link
Contributor

Hi Jitendra,

This pull request doesn't solve the bug but rather contains only the unit test method that I believe reproduces the
issue.

I would like you to review and confirm that my understanding of the expected Table.render() method behaviour is
correct. Without doubt, the unit test will help validate the actual fixture.

Adriano

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks

@adhocore
Copy link
Owner

however tests seems failing, please recheck https://github.com/adhocore/php-cli/actions/runs/14956185929/job/42012171472#step:6:48

@adhocore
Copy link
Owner

adhocore commented May 11, 2025

another PR #126 is merged already, i will release a new version once this one gets merged too

@acataluddi
Copy link
Contributor Author

however tests seems failing, please recheck https://github.com/adhocore/php-cli/actions/runs/14956185929/job/42012171472#step:6:48

Hi Jitendra,

Yes, that's "expected" because I've only implemented the unit test reproducing the bug described in #127.

I haven't had time to dig into it and I was wondering whether it was immediate for you to continue this branch and figure out the solution, as you know the internals.

Thanks,
Adriano

@adhocore
Copy link
Owner

hi Adriano, unfortunately i am unable to pick it up at this time, i have released new version with other PR.

@acataluddi acataluddi changed the title Implemented unit test do track the visualisation bug in #127. Implemented unit test to track the visualisation bug in #127. May 12, 2025
@adhocore adhocore marked this pull request as draft May 12, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants