Skip to content

Commit

Permalink
adjust ts
Browse files Browse the repository at this point in the history
  • Loading branch information
adidahiya committed Dec 18, 2024
1 parent a94ac8c commit de900d5
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 5 deletions.
3 changes: 2 additions & 1 deletion config/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"esModuleInterop": true,
"experimentalDecorators": true,
"importHelpers": true,
"lib": ["es5", "es2015", "es2016", "es2017", "es2018", "es2019", "es2020"],
// HACKHACK: @types/react-dom is being included in all packages, which requires dom types
"lib": ["dom", "es5", "es2015", "es2016", "es2017", "es2018", "es2019", "es2020"],
"module": "nodenext",
"moduleResolution": "nodenext",
"noFallthroughCasesInSwitch": true,
Expand Down
1 change: 1 addition & 0 deletions packages/raga-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"@electron-forge/maker-zip": "^7.6.0",
"@electron-forge/plugin-vite": "^7.6.0",
"@types/app-root-dir": "^0.1.4",
"@types/chroma-js": "^2.4.5",
"@types/node": "^22.10.2",
"@types/react": "^19.0.1",
"@types/react-devtools": "^3.6.2",
Expand Down
3 changes: 2 additions & 1 deletion packages/raga-app/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
"include": ["src"],
"compilerOptions": {
"jsx": "react-jsx",
"lib": ["dom", "es5", "es2015", "es2016", "es2017", "es2018", "es2019", "es2020"],
// HACKHACK due to https://github.com/table-library/react-table-library/issues/145
// Since then, we've also accumulated a few other lib type issues (@tinyhttp/app, file-selector,
// and others related to react JSX namespace deprecation)
"skipLibCheck": true,
"module": "ESNext",
"moduleResolution": "Bundler",
Expand Down
4 changes: 1 addition & 3 deletions packages/raga-lib/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"include": ["src"],
"compilerOptions": {
"declaration": true,
"outDir": "./lib/",
// HACKHACK: @types/react-dom is being included for some reason, and we don't have dom types here
"skipLibCheck": true
"outDir": "./lib/"
}
}
8 changes: 8 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ __metadata:
"@table-library/react-table-library": "npm:^4.1.7"
"@tinyhttp/app": "npm:^2.5.0"
"@types/app-root-dir": "npm:^0.1.4"
"@types/chroma-js": "npm:^2.4.5"
"@types/node": "npm:^22.10.2"
"@types/react": "npm:^19.0.1"
"@types/react-devtools": "npm:^3.6.2"
Expand Down Expand Up @@ -2804,6 +2805,13 @@ __metadata:
languageName: node
linkType: hard

"@types/chroma-js@npm:^2.4.5":
version: 2.4.5
resolution: "@types/chroma-js@npm:2.4.5"
checksum: 10/8b4eeb55ff122d758a598a014f5e7ad14bbc5cfe45ce10a907f33b3d4082e1921655bc83dbaf6728886f4344ee78301b2934ad319656845208ee0164a90a5051
languageName: node
linkType: hard

"@types/dedent@npm:^0.7.2":
version: 0.7.2
resolution: "@types/dedent@npm:0.7.2"
Expand Down

0 comments on commit de900d5

Please sign in to comment.