Skip to content

FORMS-18927 Added support for custom extensions using the edit dialogue #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

FORMS-18927 Added support for custom extensions using the edit dialogue #1541

wants to merge 17 commits into from

Conversation

rajatofficial
Copy link
Contributor

Allowed file types support new MIME types or extensions in AEM Forms File Attachment component.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

rismehta
rismehta requested changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test collateral for this

@rismehta
Copy link
Collaborator

rismehta commented Mar 7, 2025

I have already fixed the flaky test, please re-sync with dev and add automation test case for the current change

@github-actions github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 252a0a6 to 85644fa Compare March 10, 2025 09:36
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@github-actions github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 4cde36d to 8f6370c Compare March 13, 2025 09:41
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (6313288) to head (3598361).

Files with missing lines Patch % Lines
...nents/internal/models/v3/form/FileInputImplV3.java 50.00% 2 Missing and 1 partial ⚠️
...q/forms/core/components/models/form/FileInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #1541      +/-   ##
============================================
- Coverage     82.32%   82.22%   -0.10%     
- Complexity     1000     1002       +2     
============================================
  Files           108      108              
  Lines          2603     2611       +8     
  Branches        370      371       +1     
============================================
+ Hits           2143     2147       +4     
- Misses          272      275       +3     
- Partials        188      189       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rajatofficial rajatofficial force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch 2 times, most recently from de85449 to b0c4425 Compare April 1, 2025 05:12
@github-actions github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from d8110d5 to 9d8ddba Compare April 25, 2025 07:26
@rajatofficial rajatofficial force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 9d8ddba to 5795dc0 Compare April 25, 2025 07:26
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rajatkhurana-adobe
added support for custom extensions using the edit dialogue
1ffbe62
@rajatkhurana-adobe
feat(FileExtensionSupport): add support for custom file extensions te…
dab954d 
…st cases
@rajatkhurana-adobe
Updated help description to support file extensions as well
74ac42b
@rajatkhurana-adobe
added support for new extesnions in the file input with test cases
b26fe17
@rajatkhurana-adobe
feat(FileExtensionSupport): add support for custom file extensions te…
dc78624 
…st cases
@rajatkhurana-adobe
Updated help description to support file extensions as well
832ed88
@rajatkhurana-adobe
added support for new extesnions removed extra changes from other ver…
16a6a6a 
…sions
@rajatkhurana-adobe
feat(newExtensionsSupport): test cases fixed
69dfe31
@rajatkhurana-adobe
added new support for extensions
81b75c7
@rajatkhurana-adobe
hiding info icon as per extensions support
9d5a826
@rajatkhurana-adobe
file extensions masking removed
7e93f33
@rajatkhurana-adobe
Test cases for model added
db44ec5
@rajatkhurana-adobe
test cases fixed
4e1285d
@rajatkhurana-adobe
test cases fixed I
3618248
@rajatkhurana-adobe
test cases fixed for extensions support in file input
55ad1a9
@rajatkhurana-adobe
test cases fixed for extensions support in file input
5951ad8
@rajatkhurana-adobe
File Type and file extensions descriptions added
793ac61
@github-actions github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 920a278 to 793ac61 Compare May 7, 2025 04:41
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rismehta rismehta rismehta requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajatofficial @adobe-bot @rismehta @rajatkhurana-adobe