feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components #1567

DhruvSharma-845 · 2025-03-27T18:31:12Z

Description

Adding pageTemplate in FormContainer to describe master page related properties for DoR.
Adding dorContainer in each Component to describe print related properties for DoR.
Print specific properties will be exported in CRISPR json only when present in JCR(i.e. in case of print only).
Adding new components for print: PageSet, PageArea, Content, Medium and Proto. Keeping the implementations in a separate module.

Related Issue

Motivation and Context

It will enable the support for print related properties in CRISPR json(mainly layout and style related properties).

How Has This Been Tested?

UTs have been added.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

codecov · 2025-03-27T18:34:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (42562b2) to head (8a3b3e8).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1567      +/-   ##
============================================
- Coverage     82.32%   82.22%   -0.11%     
- Complexity     1000     1008       +8     
============================================
  Files           108      108              
  Lines          2603     2633      +30     
  Branches        370      377       +7     
============================================
+ Hits           2143     2165      +22     
- Misses          272      278       +6     
- Partials        188      190       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

adobe-bot · 2025-03-27T18:51:33Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	99	96	96	75

adobe-bot · 2025-03-27T18:51:33Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	86	96	96	75

adobe-bot · 2025-03-27T18:51:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-03-27T18:51:47Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-27T18:52:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-27T20:04:02Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	96	96	75

adobe-bot · 2025-03-27T20:04:02Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	99	96	96	75

adobe-bot · 2025-03-27T20:04:15Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-27T20:04:29Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-03-27T20:07:06Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

rismehta · 2025-03-28T09:55:22Z

bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/Barcode.java

@@ -0,0 +1,21 @@
+/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Please add these interfaces in a different package inside form

adobe-bot · 2025-03-28T17:03:30Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-03-28T17:03:30Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-03-28T17:03:41Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-28T17:04:41Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-28T17:04:48Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

DhruvSharma-845 · 2025-03-28T17:24:15Z

...af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractFormComponentImpl.java

+    @JsonIgnore
+    public Map<String, Object> getDorContainer() {
+        if (resource != null) {
+            Resource dorContainerResource = resource.getChild("fd:dorContainer");


@rismehta : Here I am assuming dorContainer node will be named as fd:dorContainer in JCR, keeping it in consistency with fd:rules and 'fd:events. I hope it is okay.

take this in spec review meeting

DhruvSharma-845 · 2025-03-28T17:27:41Z

.../main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java

        return customDorProperties;
    }

+    private Map<String, Object> getPageTemplate() {
+        if (resource != null) {
+            Resource pageTemplateResource = resource.getChild("fd:pagetemplate");


@rismehta : pageTemplate node is assumed to be persisted with name fd:pageTemplate. I hope it is fine.

DhruvSharma-845 · 2025-03-28T17:30:03Z

bundles/af-core/src/test/java/com/adobe/cq/forms/core/Utils.java

@@ -126,14 +128,14 @@ public static void testSchemaValidation(@NotNull Object model) {
        // create an instance of the JsonSchemaFactory using version flag
        JsonSchemaFactory schemaFactory = JsonSchemaFactory.getInstance(SpecVersion.VersionFlag.V7);
        try {
-            InputStream schemaStream = Utils.class.getResourceAsStream("/schema/0.14.2/adaptive-form.schema.json");
+            InputStream schemaStream = Utils.class.getResourceAsStream("/schema/0.15.1/adaptive-form.schema.json");


@rismehta : Have added new schema files versioned 0.15.1. Also, have updated version number here in schema validation. Please let me know if anything else needs to be done w.r.t. new schema

DhruvSharma-845 · 2025-03-28T17:31:52Z

...re/src/test/resources/form/formcontainer/exporter-formContainer-cc-form-rest-submission.json

@@ -52,6 +52,6 @@
        "grammar": "json-formula-1.0.0",
        "version": "1.0.0"
    },
-    "adaptiveform": "0.14.2",
+    "adaptiveform": "0.15.1",


@rismehta :
Updating version number here in test baseline files is breaking a PR check. What is the right way to update this files?

adobe-bot · 2025-03-28T17:46:34Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	96	96	75

adobe-bot · 2025-03-28T17:46:34Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

…esolution

…ot in separate PrintContainer

…ific sdk

…ormComponent inetrface

adobe-bot · 2025-05-13T06:29:21Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-13T06:30:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

vdua · 2025-05-13T13:28:46Z

I have one doubt regarding the dorContainer. I thought the dorContainer properties will come with different View (not author/publish) ? I do not see that change here ?

DhruvSharma-845 · 2025-05-13T14:54:18Z

I have one doubt regarding the dorContainer. I thought the dorContainer properties will come with different View (not author/publish) ? I do not see that change here ?

I have added @JsonView annotation on getDorContainer method. Please refer here: https://github.com/adobe/aem-core-forms-components/pull/1567/files#diff-83ed79b144226c70d6b93ceaa9b25d5d243edacab1730e932f106c5e02a2df0cR84

I took the inspiration from getDorProperties method: https://github.com/adobe/aem-core-forms-components/pull/1567/files#diff-83ed79b144226c70d6b93ceaa9b25d5d243edacab1730e932f106c5e02a2df0cL73

vdua · 2025-05-14T02:36:43Z

I have one doubt regarding the dorContainer. I thought the dorContainer properties will come with different View (not author/publish) ? I do not see that change here ?

I have added @JsonView annotation on getDorContainer method. Please refer here: https://github.com/adobe/aem-core-forms-components/pull/1567/files#diff-83ed79b144226c70d6b93ceaa9b25d5d243edacab1730e932f106c5e02a2df0cR84

I took the inspiration from getDorProperties method: https://github.com/adobe/aem-core-forms-components/pull/1567/files#diff-83ed79b144226c70d6b93ceaa9b25d5d243edacab1730e932f106c5e02a2df0cL73

Sorry. Missed that. Looks okay to me.

vdua

LGTM. Ensure

the tests pass before merging
use squash and merge rather than adding these 571 commits to the repo.

adobe-bot · 2025-05-14T06:01:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-05-14T06:01:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

DhruvSharma-845 self-assigned this Mar 27, 2025

DhruvSharma-845 added enhancement New feature or request java Pull requests that update Java code labels Mar 27, 2025

DhruvSharma-845 requested review from rismehta and vdua March 27, 2025 19:51

rismehta reviewed Mar 28, 2025

View reviewed changes

DhruvSharma-845 commented Mar 28, 2025

View reviewed changes

DhruvSharma-845 added 21 commits May 13, 2025 06:07

feat(print-properties): RTC - Adding UTs for print specific interfaces

fd61e5c

feat(print-properties): RTC - Adding UTs for print specific interfaces

5d38f1d

feat(print-properties): Adding DoR view and correcting a typo

106e4a2

feat(print-properties): Adding more UTs

f31f53a

feat(print-properties): Removing print related files

0ff204a

feat(print-properties): Reformatting to avoid unnecessary changes

663902b

feat(print-properties): Removing unnecessary file

e983814

feat(print-properties): Removing unnecessary file

64dc876

feat(print-properties): Refactoring changes

ae01455

feat(print-properties): Fixing issues with rebasing

e5b0758

feat(print-properties): Import sorting

5d1d584

feat(print-properties): Removing unnecessary file

553842c

feat(print-properties): Removing synthetic resource changes

89b76ac

feat(print-properties): Adding test case for channel based fragment r…

7baa39b

…esolution

feat(print-properties): Removing the pageTemplate handling as it is n…

96a1021

…ot in separate PrintContainer

feat(print-properties): Removing code came due to merge conflicts

39b53f7

feat(print-properties): Removing new schema; it is used in print spec…

6c248f2

…ific sdk

feat(print-properties): Removing new field types

0d24201

feat(print-properties): Updating version of dor api package

ccc0afd

feat(print-properties): Converting string literals to constants

993df8f

feat(print-properties): Adding test case for getDorContainer in the F…

e6fcb2b

…ormComponent inetrface

github-actions bot force-pushed the print-core-components-models branch from 0f90aa9 to e6fcb2b Compare May 13, 2025 06:07

vdua approved these changes May 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components #1567

feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components #1567

DhruvSharma-845 commented Mar 27, 2025 •

edited

Loading

codecov bot commented Mar 27, 2025 •

edited

Loading

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

adobe-bot commented Mar 27, 2025

rismehta Mar 28, 2025

DhruvSharma-845 Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented Mar 28, 2025

DhruvSharma-845 Mar 28, 2025

sakshi-arora1 May 13, 2025

DhruvSharma-845 Mar 28, 2025 •

edited

Loading

DhruvSharma-845 Mar 28, 2025

DhruvSharma-845 Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented Mar 28, 2025

adobe-bot commented May 13, 2025

adobe-bot commented May 13, 2025

vdua commented May 13, 2025

DhruvSharma-845 commented May 13, 2025 •

edited

Loading

vdua commented May 14, 2025

vdua left a comment

adobe-bot commented May 14, 2025

adobe-bot commented May 14, 2025

		@@ -0,0 +1,21 @@
		/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

feat(print-properties): Adding dorContainer in each component and pageTemplate in FormContainer and new print specific components #1567

Are you sure you want to change the base?

feat(print-properties): Adding dorContainer in each component and pageTemplate in FormContainer and new print specific components #1567

Conversation

DhruvSharma-845 commented Mar 27, 2025 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov bot commented Mar 27, 2025 • edited Loading

Codecov Report

adobe-bot commented Mar 27, 2025

Lighthouse scores (desktop)

adobe-bot commented Mar 27, 2025

Lighthouse scores (mobile)

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

adobe-bot commented Mar 27, 2025

Lighthouse scores (mobile)

adobe-bot commented Mar 27, 2025

Lighthouse scores (desktop)

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

adobe-bot commented Mar 27, 2025

Accessibility Violations Found

rismehta Mar 28, 2025

Choose a reason for hiding this comment

DhruvSharma-845 Mar 28, 2025

Choose a reason for hiding this comment

adobe-bot commented Mar 28, 2025

Lighthouse scores (desktop)

adobe-bot commented Mar 28, 2025

Lighthouse scores (mobile)

adobe-bot commented Mar 28, 2025

Accessibility Violations Found

adobe-bot commented Mar 28, 2025

Accessibility Violations Found

adobe-bot commented Mar 28, 2025

Accessibility Violations Found

DhruvSharma-845 Mar 28, 2025

Choose a reason for hiding this comment

sakshi-arora1 May 13, 2025

Choose a reason for hiding this comment

DhruvSharma-845 Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

DhruvSharma-845 Mar 28, 2025

Choose a reason for hiding this comment

DhruvSharma-845 Mar 28, 2025

Choose a reason for hiding this comment

adobe-bot commented Mar 28, 2025

Lighthouse scores (mobile)

adobe-bot commented Mar 28, 2025

Lighthouse scores (desktop)

adobe-bot commented May 13, 2025

Accessibility Violations Found

adobe-bot commented May 13, 2025

Accessibility Violations Found

vdua commented May 13, 2025

DhruvSharma-845 commented May 13, 2025 • edited Loading

vdua commented May 14, 2025

vdua left a comment

Choose a reason for hiding this comment

adobe-bot commented May 14, 2025

Accessibility Violations Found

adobe-bot commented May 14, 2025

Accessibility Violations Found

feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components #1567

feat(print-properties): Adding `dorContainer` in each component and `pageTemplate` in FormContainer and new print specific components #1567

DhruvSharma-845 commented Mar 27, 2025 •

edited

Loading

codecov bot commented Mar 27, 2025 •

edited

Loading

DhruvSharma-845 Mar 28, 2025 •

edited

Loading

DhruvSharma-845 commented May 13, 2025 •

edited

Loading