Fix tests for edgeConfigOverrides and Streaming Media #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
requested changes
Oct 29, 2024
| @@ -130,6 +130,7 @@ describe("StreamingMedia::createMediaEventManager", () => { | |||
| }); | |||
| expect(eventManager.sendEvent).toHaveBeenCalledWith(event, { | |||
| mediaOptions, | |||
| edgeConfigOverrides: undefined, | |||
There was a problem hiding this comment.
Instead of changing the test to have edgeConfigOverrides: undefined, we should continue the work of #1199 and modify src/core/createEventManager.js to not include empty edgeConfigOverrides in the call to sendEvent
There was a problem hiding this comment.
It is using src/core/createEventManager.js down the line, which checks the edgeConfigOverrides and construct the request payload based on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: