Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option validation to the setDebug command. #1209

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

shammowla
Copy link
Collaborator

Summary

Added input validation for the setDebug command to provide clearer error messages when invalid options are passed. Previously, passing invalid options to setDebug would result in generic errors. Now, users receive specific validation errors with documentation references.

Changes

  • Added validation error handling with clear error messages and documentation links
  • Updated tests in injectExecuteCommand.spec.js to verify validation behavior

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@shammowla shammowla requested a review from jonsnyder November 1, 2024 16:01
@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Nov 1, 2024
@jonsnyder jonsnyder removed the ignore-for-release Do not include this PR in release notes label Nov 1, 2024
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@jonsnyder jonsnyder changed the title Add option validation to setDebug command. Added option validation to the setDebug command. Nov 1, 2024
@shammowla shammowla merged commit 84ac54f into main Nov 4, 2024
4 of 6 checks passed
@shammowla shammowla deleted the PDCL-10788 branch November 4, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants