fix: ensure that rowspan is bound to table limits (#166)

adobe · Feb 25, 2025 · 3195c5d · 3195c5d
1 parent f41b4a5
commit 3195c5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/to-markdown.js b/src/to-markdown.js
@@ -227,6 +227,8 @@ class Table {
         if (cell.tree) {
           realNumCols = Math.max(realNumCols, x + 1);
         }
+        // ensure rowspan is not too large
+        cell.rowSpan = Math.min(cell.rowSpan, this.rows.length - y);
         if (cell.rowSpan > 1) {
           // insert colspan amount of null cells below
           for (let i = 1; i < cell.rowSpan; i += 1) {

diff --git a/test/gridtable-to-md.test.js b/test/gridtable-to-md.test.js
@@ -370,7 +370,7 @@ describe('gridtable to md', () => {
           cell(text('B7'), 1, 1),
         ]),
         gtRow([
-          cell(text('AB8'), 1, 2),
+          cell(text('AB8'), 2, 2),
         ]),
       ]),
       heading(2, text('Table with overlapping spans')),