feat: Async loading support for S2 ComboBox/Picker #7938

LFDanLu · 2025-03-14T22:44:51Z

Closes

Adds loading support for S2 ComboBox/Picker and their RAC equivalents (and RAC ListBox too since that is what ComboBox and Picker uses
refactors useLoadMore to accept collections instead of items

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test S2 Combobox/Picker async loading stories and make sure it works as expected (aka infinite scrolling). Also test the RAC equivalents as well as S2 CardView/Table/other components that already had async loading support.

🧢 Your Project:

RSP

…and data-attributes

rspbot · 2025-03-15T00:38:52Z

Build successful! 🎉

rspbot · 2025-03-17T17:27:34Z

Build successful! 🎉

…oad more like v3

rspbot · 2025-03-18T22:38:53Z

Build successful! 🎉

rspbot · 2025-03-19T00:07:14Z

Build successful! 🎉

rspbot · 2025-04-09T21:18:16Z

Build successful! 🎉

LFDanLu · 2025-04-10T20:19:01Z

packages/@react-aria/utils/src/useLoadMore.ts

Make a new hook since util package version might not match up with pinned version of tableview/etc, which makes this a breaking change

…ectrum into s2-combobox-picker-virtualizer

the document didnt seem to be both updating its _minInvalidChildIndex nor updating its child indicies properly when the combobox list was filtered async (aka the collection got new items added and removed via insertBefore and/or removeChild. Additionally, we didnt see to ever call updateChildIndices on the Document other than the first time the collection loaded

LFDanLu · 2025-05-06T17:59:52Z

packages/react-aria-components/src/Virtualizer.tsx

+  // TODO: wull have to update this when multi section loading is implemented, will need to check if all items in a collection are loaders instead perhaps
+  let hasLoadingSentinel = collection.size === 1 && collection.getItem(collection.getFirstKey()!)!.type === 'loader';
+  if (state.contentSize.area === 0 && !hasLoadingSentinel) {


This will change with https://github.com/adobe/react-spectrum/pull/8110/files#diff-6026043a183382ab1099d5cc5c47d7028cef57057d81b9dfc55acfba173e6d0f, can remove this logic then

LFDanLu · 2025-05-06T18:23:49Z

packages/@react-aria/collections/src/Document.ts

@@ -103,7 +103,7 @@ export class BaseNode<T> {
  }

  private invalidateChildIndices(child: ElementNode<T>): void {
-    if (this._minInvalidChildIndex == null || child.index < this._minInvalidChildIndex.index) {
+    if (this._minInvalidChildIndex == null || !this._minInvalidChildIndex.isConnected || child.index < this._minInvalidChildIndex.index) {


I found cases where the minInvalidChildIndex set on the Document was pointing to nodes that didn't exist in the collection any more so added this check so we'd always have an up to date one

sounds maybe related to #8127?

yeah a bit, definitely solves a part of that issue

LFDanLu · 2025-05-06T18:26:41Z

packages/@react-aria/collections/src/Document.ts

+    // Is element.updateNode supposed to handle that (it currently assumes the index stored on the node is correct already).
+    // At the moment, without this call to updateChildIndicies, filtering an async combobox doesn't actually update the index values of the
+    // updated collection...
+    this.updateChildIndices();


This change along with the above were mainly to fix an issue I noticed where the collection indexes weren't updating when filtering the combobox. Above, we properly update the childIndices of the Document's dirty nodes (aka the children's children) but not for the main children. Not sure if the call to element.updateNode below is supposed to handle this but this felt the most correct

shouldn't the document be in the list of dirtyNodes then and therefore get processed by the above loop?

also is the todo still relevant?

The todo is part of the comment above, basically just noting that I'm not 100% sure about the change. From what I observed the document never marks itself as dirty when performing insertBefore operations, only when calling appendChild or if setFirstChild gets hit in insertBefore. Instead of this change, I could add this.ownerDocument.markDirty(this); to BaseNode's insertBefore and removeChild but it felt safer to isolate it here to updateCollection as a "end step" of sorts

LFDanLu · 2025-05-06T18:29:21Z

packages/react-aria-components/test/ListBox.test.js

+      // TODO: for some reason this tree renders empty if ran with the above test...
+      // Even if the above test doesn't do anything within it, the below tree won't render with content until the above test
+      // is fully commented out (aka even the it(...))
+      // It thinks that the contextSize is 0 and never updates
+      it.skip('should not reserve room for the loader if isLoading is false', () => {


Not quite sure why this is happening... As stated, the below test only renders the listbox items if the above test is completely commented out. Even if the above test doesn't have any contents (aka just an empty it()) this test still fails to render the ListBox content

rspbot · 2025-05-06T18:32:03Z

Build successful! 🎉

packages/@react-aria/collections/src/Document.ts

snowystinger · 2025-05-07T04:49:42Z

packages/@react-aria/interactions/src/usePress.ts

@@ -372,7 +372,7 @@ export function usePress(props: PressHookProps): PressResult {
          if (isDisabled) {
            e.preventDefault();
          }
-          
+


could undo the changes in this file to cut down on changes/files touched

snowystinger · 2025-05-07T05:26:39Z

packages/@react-aria/utils/src/useLoadMoreSentinel.ts

+   * @default 1
+   */
+  scrollOffset?: number
+  // TODO: Maybe include a scrollRef option so the user can provide the scrollParent to compare against instead of having us look it up


would that be different than the ref already provided? a ref to the scrollable region seems like a good idea so that eventually people can use something like body element scrolling to drive the virtualizer

snowystinger · 2025-05-07T05:36:08Z

packages/@react-aria/utils/src/useLoadMoreSentinel.ts

+
+  useLayoutEffect(() => {
+    if (ref.current) {
+      // Tear down and set up a new IntersectionObserver when the collection changes so that we can properly trigger additional loadMores if there is room for more items


seems fine, certainly more readable than separating it into some other effect and has the benefit of being queued in the same way as the rest of the IntersectionObserver updates

snowystinger · 2025-05-07T05:37:41Z

packages/@react-aria/virtualizer/src/ScrollView.tsx

@@ -209,7 +209,11 @@ export function useScrollView(props: ScrollViewProps, ref: RefObject<HTMLElement
      // https://github.com/reactwg/react-18/discussions/102
      // @ts-ignore
      if (typeof IS_REACT_ACT_ENVIRONMENT === 'boolean' ? IS_REACT_ACT_ENVIRONMENT : typeof jest !== 'undefined') {
-        updateSize(fn => fn());
+        // This is so we update size in a separate render but within the same act. Needs to be setState instead of refs


why? is there some event we could hook into instead?

This is to specifically fix the tests where the order in which things run (such as when the ref is connected to the ScrollView and when we perform rect measurements) vs how focus is moved by simulated clicks/presses from userEvent was causing odd behaviors (i.e. focus would move to the trigger button -> the dropdown -> back to the button specifically due to the order in which the dropdown becomes available/focusable + preventFocus's logic thinking it should then restore focus to the button vs how it happens in the browser with the dropdown becoming available after that preventFocus logic runs).

The only way to fix this was to make sure the size of the ScrollView updates in a separate render but within the same act, but ideally the high level flow should be that focus moves to the Picker trigger on click -> all press handling finishes -> collection is fully formed -> dropdown opens and focus moves into it.

packages/react-aria-components/src/GridList.tsx

snowystinger · 2025-05-07T06:06:05Z

packages/react-aria-components/src/GridList.tsx

+
+  return (
+    <>
+      {/* TODO: Alway render the sentinel. Will need to figure out how best to position this in cases where the user is using flex + gap (this would introduce a gap even though it doesn't take room) */}


users will have to do it depending on their approach I think

snowystinger · 2025-05-07T06:07:51Z

packages/react-aria-components/src/Table.tsx

-        <TD role="rowheader" {...rowHeaderProps} style={style}>
-          {renderProps.children}
-        </TD>
+      {/* TODO weird structure? Renders a extra row but we hide via inert so maybe ok? */}


Going to be problematic for the work Yihui is doing to keyboard navigate to the the loader

we could perhaps skip it via checking some attribute or something right?

packages/react-stately/package.json

yarn.lock

devongovett

I do think we should use the sentinel's specifically for load more, and use renderEmptyState for initial loading. That would possibly simplify some of the logic here.

packages/react-aria-components/src/ComboBox.tsx

devongovett · 2025-05-07T19:52:57Z

packages/@react-aria/collections/src/Document.ts

@@ -103,7 +103,7 @@ export class BaseNode<T> {
  }

  private invalidateChildIndices(child: ElementNode<T>): void {
-    if (this._minInvalidChildIndex == null || child.index < this._minInvalidChildIndex.index) {
+    if (this._minInvalidChildIndex == null || !this._minInvalidChildIndex.isConnected || child.index < this._minInvalidChildIndex.index) {


sounds maybe related to #8127?

devongovett · 2025-05-07T19:57:03Z

packages/@react-aria/collections/src/Document.ts

+    // Is element.updateNode supposed to handle that (it currently assumes the index stored on the node is correct already).
+    // At the moment, without this call to updateChildIndicies, filtering an async combobox doesn't actually update the index values of the
+    // updated collection...
+    this.updateChildIndices();


shouldn't the document be in the list of dirtyNodes then and therefore get processed by the above loop?

also is the todo still relevant?

devongovett · 2025-05-07T20:31:55Z

packages/@react-spectrum/s2/src/ComboBox.tsx

+  paddingStart: 'edge-to-text'
+});
+
+export let listbox = style<{size: 'S' | 'M' | 'L' | 'XL'}>({


why were all the styles copied?

packages/@react-spectrum/s2/src/ComboBox.tsx

devongovett · 2025-05-07T22:54:15Z

packages/@react-stately/layout/src/GridLayout.ts

+    let collection = this.virtualizer!.collection;
+    // Make sure to set rows to 0 if we performing a first time load or are rendering the empty state so that Virtualizer
+    // won't try to render its body
+    let isEmptyOrLoading = collection?.size === 0 || (collection.size === 1 && collection.getItem(collection.getFirstKey()!)!.type === 'loader');


if we are recommending people use renderEmptyState for initial loading, do we still need this logic?

as mentioned above, renderEmptyState is used for initial loading but the LoadingSentinel is expected to always be included as a child

devongovett · 2025-05-07T22:56:16Z

packages/@react-stately/layout/src/GridLayout.ts

+    // Always add the loader sentinel if present in the collection so we can make sure it is never virtualized out.
+    let lastNode = collection.getItem(collection.getLastKey()!);
+    if (lastNode?.type === 'loader') {
+      let rect = new Rect(horizontalSpacing, y, itemWidth, 0);


hard coded zero height? also this assumes the loader is always the last item in the collection

For the CardView we don't have a spinner so I've set it to 0. Can definitely revisit if we expect multi section loading there or for a spinner to be used instead of Skeleton loading but for now I opted for the simpler change

probably will need to be revisited for RAC users too. there might be a spinner there

right good point, I'll add a todo so I don't forget

packages/@react-stately/select/src/useSelectState.ts

devongovett · 2025-05-07T23:04:33Z

packages/react-aria-components/src/GridList.tsx

+  // TODO: What do we think about this check? Ideally we could just query the collection and see if ALL node are loaders and thus have it return that it is empty
+  let isEmpty = state.collection.size === 0 || (state.collection.size === 1 && state.collection.getItem(state.collection.getFirstKey()!)?.type === 'loader');


could remove if initial loading state was handled in renderEmptyState

…ct-spectrum into loadmore_rac

rspbot · 2025-05-09T00:15:32Z

Build successful! 🎉

rspbot · 2025-05-09T00:44:42Z

Build successful! 🎉

rspbot · 2025-05-09T19:17:41Z

Build successful! 🎉

rspbot · 2025-05-09T19:17:42Z

## API Changes

react-aria-components

/react-aria-components:UNSTABLE_TableLoadingIndicator

-UNSTABLE_TableLoadingIndicator <T extends {}> {
-  children?: ReactNode
-  className?: string
-  style?: CSSProperties
-}

/react-aria-components:UNSTABLE_GridListLoadingSentinel

+UNSTABLE_GridListLoadingSentinel <T extends {}> {
+  children?: ReactNode
+  className?: string
+  isLoading?: boolean
+  onLoadMore?: () => any
+  scrollOffset?: number = 1
+  style?: CSSProperties
+}

/react-aria-components:UNSTABLE_ListBoxLoadingSentinel

+UNSTABLE_ListBoxLoadingSentinel <T extends {}> {
+  children?: ReactNode
+  className?: string
+  isLoading?: boolean
+  onLoadMore?: () => any
+  scrollOffset?: number = 1
+  style?: CSSProperties
+}

/react-aria-components:UNSTABLE_TableLoadingSentinel

+UNSTABLE_TableLoadingSentinel <T extends {}> {
+  children?: ReactNode
+  className?: string
+  isLoading?: boolean
+  onLoadMore?: () => any
+  scrollOffset?: number = 1
+  style?: CSSProperties
+}

@react-aria/utils

/@react-aria/utils:UNSTABLE_useLoadMoreSentinel

+UNSTABLE_useLoadMoreSentinel {
+  props: LoadMoreSentinelProps
+  ref: RefObject<HTMLElement | null>
+  returnVal: undefined
+}

/@react-aria/utils:LoadMoreSentinelProps

+LoadMoreSentinelProps {
+  collection: Collection<Node<unknown>>
+  onLoadMore?: () => any
+  scrollOffset?: number = 1
+}

@react-spectrum/s2

/@react-spectrum/s2:ComboBox

 ComboBox <T extends {}> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   align?: 'start' | 'end' = 'start'
   allowsCustomValue?: boolean
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoFocus?: boolean
   children: ReactNode | ({}) => ReactNode
   contextualHelp?: ReactNode
   defaultInputValue?: string
   defaultItems?: Iterable<T>
   defaultSelectedKey?: Key
   description?: ReactNode
   direction?: 'bottom' | 'top' = 'bottom'
   disabledKeys?: Iterable<Key>
   errorMessage?: ReactNode | (ValidationResult) => ReactNode
   formValue?: 'text' | 'key' = 'key'
   id?: string
   inputValue?: string
   isDisabled?: boolean
   isInvalid?: boolean
   isReadOnly?: boolean
   isRequired?: boolean
   items?: Iterable<T>
   label?: ReactNode
   labelAlign?: Alignment = 'start'
   labelPosition?: LabelPosition = 'top'
+  loadingState?: LoadingState
   menuTrigger?: MenuTriggerAction = 'input'
   menuWidth?: number
   name?: string
   necessityIndicator?: NecessityIndicator = 'icon'
   onBlur?: (FocusEvent<HTMLInputElement>) => void
   onFocus?: (FocusEvent<HTMLInputElement>) => void
   onFocusChange?: (boolean) => void
   onInputChange?: (string) => void
   onKeyDown?: (KeyboardEvent) => void
   onKeyUp?: (KeyboardEvent) => void
+  onLoadMore?: () => any
   onOpenChange?: (boolean, MenuTriggerAction) => void
   onSelectionChange?: (Key | null) => void
   selectedKey?: Key | null
   shouldFlip?: boolean = true
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
   validate?: (ComboBoxValidationValue) => ValidationError | boolean | null | undefined
   validationBehavior?: 'native' | 'aria' = 'native'
 }

/@react-spectrum/s2:Picker

 Picker <T extends {}> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   align?: 'start' | 'end' = 'start'
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoComplete?: string
   autoFocus?: boolean
   children: ReactNode | ({}) => ReactNode
   contextualHelp?: ReactNode
   defaultOpen?: boolean
   defaultSelectedKey?: Key
   description?: ReactNode
   direction?: 'bottom' | 'top' = 'bottom'
   disabledKeys?: Iterable<Key>
   errorMessage?: ReactNode | (ValidationResult) => ReactNode
   excludeFromTabOrder?: boolean
   id?: string
   isDisabled?: boolean
   isInvalid?: boolean
+  isLoading?: boolean
   isOpen?: boolean
   isRequired?: boolean
   items?: Iterable<T>
   label?: ReactNode
   labelAlign?: Alignment = 'start'
   labelPosition?: LabelPosition = 'top'
   menuWidth?: number
   name?: string
   necessityIndicator?: NecessityIndicator = 'icon'
   onBlur?: (FocusEvent<Target>) => void
   onFocus?: (FocusEvent<Target>) => void
   onFocusChange?: (boolean) => void
   onKeyDown?: (KeyboardEvent) => void
   onKeyUp?: (KeyboardEvent) => void
+  onLoadMore?: () => any
   onOpenChange?: (boolean) => void
   onSelectionChange?: (Key | null) => void
   placeholder?: string = 'Select an item' (localized)
   selectedKey?: Key | null
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
   validate?: (Key) => ValidationError | boolean | null | undefined
   validationBehavior?: 'native' | 'aria' = 'native'
 }

/@react-spectrum/s2:ComboBoxProps

 ComboBoxProps <T extends {}> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   align?: 'start' | 'end' = 'start'
   allowsCustomValue?: boolean
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoFocus?: boolean
   children: ReactNode | ({}) => ReactNode
   contextualHelp?: ReactNode
   defaultInputValue?: string
   defaultItems?: Iterable<T>
   defaultSelectedKey?: Key
   description?: ReactNode
   direction?: 'bottom' | 'top' = 'bottom'
   disabledKeys?: Iterable<Key>
   errorMessage?: ReactNode | (ValidationResult) => ReactNode
   formValue?: 'text' | 'key' = 'key'
   id?: string
   inputValue?: string
   isDisabled?: boolean
   isInvalid?: boolean
   isReadOnly?: boolean
   isRequired?: boolean
   items?: Iterable<T>
   label?: ReactNode
   labelAlign?: Alignment = 'start'
   labelPosition?: LabelPosition = 'top'
+  loadingState?: LoadingState
   menuTrigger?: MenuTriggerAction = 'input'
   menuWidth?: number
   name?: string
   necessityIndicator?: NecessityIndicator = 'icon'
   onBlur?: (FocusEvent<HTMLInputElement>) => void
   onFocus?: (FocusEvent<HTMLInputElement>) => void
   onFocusChange?: (boolean) => void
   onInputChange?: (string) => void
   onKeyDown?: (KeyboardEvent) => void
   onKeyUp?: (KeyboardEvent) => void
+  onLoadMore?: () => any
   onOpenChange?: (boolean, MenuTriggerAction) => void
   onSelectionChange?: (Key | null) => void
   selectedKey?: Key | null
   shouldFlip?: boolean = true
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
   validate?: (ComboBoxValidationValue) => ValidationError | boolean | null | undefined
   validationBehavior?: 'native' | 'aria' = 'native'
 }

/@react-spectrum/s2:PickerProps

 PickerProps <T extends {}> {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   align?: 'start' | 'end' = 'start'
   aria-describedby?: string
   aria-details?: string
   aria-label?: string
   aria-labelledby?: string
   autoComplete?: string
   autoFocus?: boolean
   children: ReactNode | ({}) => ReactNode
   contextualHelp?: ReactNode
   defaultOpen?: boolean
   defaultSelectedKey?: Key
   description?: ReactNode
   direction?: 'bottom' | 'top' = 'bottom'
   disabledKeys?: Iterable<Key>
   errorMessage?: ReactNode | (ValidationResult) => ReactNode
   excludeFromTabOrder?: boolean
   id?: string
   isDisabled?: boolean
   isInvalid?: boolean
+  isLoading?: boolean
   isOpen?: boolean
   isRequired?: boolean
   items?: Iterable<T>
   label?: ReactNode
   labelAlign?: Alignment = 'start'
   labelPosition?: LabelPosition = 'top'
   menuWidth?: number
   name?: string
   necessityIndicator?: NecessityIndicator = 'icon'
   onBlur?: (FocusEvent<Target>) => void
   onFocus?: (FocusEvent<Target>) => void
   onFocusChange?: (boolean) => void
   onKeyDown?: (KeyboardEvent) => void
   onKeyUp?: (KeyboardEvent) => void
+  onLoadMore?: () => any
   onOpenChange?: (boolean) => void
   onSelectionChange?: (Key | null) => void
   placeholder?: string = 'Select an item' (localized)
   selectedKey?: Key | null
   size?: 'S' | 'M' | 'L' | 'XL' = 'M'
   slot?: string | null
   styles?: StylesProp
   validate?: (Key) => ValidationError | boolean | null | undefined
   validationBehavior?: 'native' | 'aria' = 'native'
 }

LFDanLu added 11 commits March 7, 2025 16:36

initial support for async loading in Combobox/picker/listbox in RAC

c4ca76d

test against Listbox standalone and put on content size change issue

8ee20f9

update S2 CardView/RAC GridList for new useLoadMore

c2a1cf9

fix v3 load more stories and tests

765b757

update table to call useLoadMore internally

7708b81

first attempt at refactoring useLoadmore

2da7d04

refactor useLoadMore to get rid of scroll handlers

0bb9f21

Add S2 Picker async support, support horizontal scrolling, fix types …

0049153

…and data-attributes

async support for S2 combobox

76e1a05

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

68033b2

fix lint and add horizontal scrolling story

54fcbaa

hack together async listbox virtualized example

4d3bb6c

LFDanLu added 3 commits March 18, 2025 09:50

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

f6ba68a

add loading spinners to RAC stories

3fe09f6

fix FF load more resizable wrapping container table, make s2 picker l…

0b06824

…oad more like v3

update S2 Picker/Combobox so they are described by loading spinner

da166f2

fix Talkback and NVDA announcements for loading spinner

0ef52ef

LFDanLu added the in sprint label Mar 19, 2025

LFDanLu changed the title ~~feat: (WIP) Async loading support for S2 ComboBox and Picker~~ feat: (WIP) Async loading support for S2 ComboBox/Picker and multilevel Tree loading Apr 8, 2025

LFDanLu added 2 commits April 9, 2025 13:59

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

51580d7

clean up some todos

76dc08a

LFDanLu force-pushed the loadmore_rac branch from f9aea93 to 76dc08a Compare April 9, 2025 21:08

LFDanLu changed the title ~~feat: (WIP) Async loading support for S2 ComboBox/Picker and multilevel Tree loading~~ feat: Async loading support for S2 ComboBox/Picker Apr 9, 2025

LFDanLu marked this pull request as ready for review April 9, 2025 21:12

LFDanLu commented Apr 10, 2025

View reviewed changes

yihuiliao and others added 6 commits May 5, 2025 14:33

fix overflow on windows potentially...

cb52f58

Merge branch 'select-scrollview' of https://github.com/adobe/react-sp…

112df59

…ectrum into s2-combobox-picker-virtualizer

make S2 picker button not throw warning when rending in fake DOM

69b7db1

fix s2 picker scroll selected item into view

3cbb286

fix lint

923e260

LFDanLu commented May 6, 2025

View reviewed changes

LFDanLu added 2 commits May 6, 2025 11:03

clean up and add row index tests for GridList and Table

a2049ab

small improvements from testing session

65c2aca

LFDanLu commented May 6, 2025

View reviewed changes

yihuiliao added 2 commits May 6, 2025 14:59

update yarn lock

01ead63

remove comment

3ae8f29

snowystinger reviewed May 7, 2025

View reviewed changes

devongovett reviewed May 7, 2025

View reviewed changes

LFDanLu added 7 commits May 7, 2025 16:18

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

32c3792

review comments

1680885

Merge branch 's2-combobox-picker-virtualizer' of github.com:adobe/rea…

935e439

…ct-spectrum into loadmore_rac

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

8bd923f

missed yarn.lock conflict

f4e5f0d

fix picker test

a69f298

mixed up which react-dom dep to remove derp

67423b2

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

52e04bc

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

fb0aff3

		// TODO: What do we think about this check? Ideally we could just query the collection and see if ALL node are loaders and thus have it return that it is empty
		let isEmpty = state.collection.size === 0 \|\| (state.collection.size === 1 && state.collection.getItem(state.collection.getFirstKey()!)?.type === 'loader');

feat: Async loading support for S2 ComboBox/Picker #7938

Are you sure you want to change the base?

feat: Async loading support for S2 ComboBox/Picker #7938

Conversation

LFDanLu commented Mar 14, 2025 • edited Loading

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

rspbot commented Mar 15, 2025

rspbot commented Mar 17, 2025

rspbot commented Mar 18, 2025

rspbot commented Mar 19, 2025

rspbot commented Apr 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rspbot commented May 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devongovett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rspbot commented May 9, 2025

rspbot commented May 9, 2025

rspbot commented May 9, 2025

rspbot commented May 9, 2025

react-aria-components

/react-aria-components:UNSTABLE_TableLoadingIndicator

/react-aria-components:UNSTABLE_GridListLoadingSentinel

/react-aria-components:UNSTABLE_ListBoxLoadingSentinel

/react-aria-components:UNSTABLE_TableLoadingSentinel

@react-aria/utils

/@react-aria/utils:UNSTABLE_useLoadMoreSentinel

/@react-aria/utils:LoadMoreSentinelProps

@react-spectrum/s2

/@react-spectrum/s2:ComboBox

/@react-spectrum/s2:Picker

/@react-spectrum/s2:ComboBoxProps

/@react-spectrum/s2:PickerProps

LFDanLu commented Mar 14, 2025 •

edited

Loading