Skip to content

Added triggerRef to s2 popover #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added triggerRef to s2 popover #8193

wants to merge 3 commits into from

Conversation

biswarisomya
Copy link

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger
Copy link
Member

Thanks for the interest. Can you explain more about your use case and why you've opened this PR? What problem is it offering to solve?

sbiswari added 2 commits May 7, 2025 18:18
Refactor Popover component to use isOpen and onOpenChange props, remo…
3d6979a 
…ving deprecated button handling logic. Update stories to demonstrate new trigger functionality.
Update PopoverDialogProps to include triggerRef, isOpen, and onOpenCh…
3112464 
…ange properties for improved prop management.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biswarisomya @snowystinger