-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(usePress): add global touch-action style for pressable elements #8200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+61
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
commented
May 7, 2025
devongovett
reviewed
May 7, 2025
nwidynski
reviewed
May 7, 2025
snowystinger
reviewed
May 7, 2025
snowystinger
previously approved these changes
May 7, 2025
snowystinger
reviewed
May 7, 2025
snowystinger
previously approved these changes
May 8, 2025
devongovett
reviewed
May 8, 2025
snowystinger
approved these changes
May 8, 2025
devongovett
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested original android reproduction in mobile emulation mode and confirmed it still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8086
Before:

After:

✅ Pull Request Checklist:
📝 Test Instructions:
is first
style
inhead
on pages containing one or more pressable elements (and is only added once per page).(Given the page doesn't contain a meta viewport tag with
width=device-width
)Check the computed style of a pressable element to ensure it resolves to that
touch-action
style by defaultCheck that we still avoid the onClick delay for double tap to zoom on touch devices (fix: Apply touch-action by default in usePress #8047)
🧢 Your Project: