chore: TS explicit module S2 #8397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
@snowystinger I'm not sure what specifically about the |
it's not inferring the type, i have to say what it is despite passing it to the TreeView |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
Jun 20, 2025
reidbarber
previously approved these changes
Jun 23, 2025
devongovett
reviewed
Jun 23, 2025
Comment on lines
+46
to
+48
| export const AccordionContext: | ||
| Context<ContextValue<Partial<AccordionProps>, DOMRefValue<HTMLDivElement>>> = | ||
| createContext<ContextValue<Partial<AccordionProps>, DOMRefValue<HTMLDivElement>>>(null); |
There was a problem hiding this comment.
You don't need to repeat the types twice:
Suggested change
| export const AccordionContext: | |
| Context<ContextValue<Partial<AccordionProps>, DOMRefValue<HTMLDivElement>>> = | |
| createContext<ContextValue<Partial<AccordionProps>, DOMRefValue<HTMLDivElement>>>(null); | |
| export const AccordionContext: Context<ContextValue<Partial<AccordionProps>, DOMRefValue<HTMLDivElement>>> = createContext(null); |
There was a problem hiding this comment.
ah, hadn't noticed that from the ts quick fix, I can update those
There was a problem hiding this comment.
nope, need to have it apparently...
devongovett
reviewed
Jun 23, 2025
| @@ -68,7 +70,9 @@ const container = style({ | |||
| /** | |||
| * An avatar group is a grouping of avatars that are related to each other. | |||
| */ | |||
| export const AvatarGroup = forwardRef(function AvatarGroup(props: AvatarGroupProps, ref: DOMRef<HTMLDivElement>) { | |||
| export const AvatarGroup: | |||
| ForwardRefExoticComponent<AvatarGroupProps & RefAttributes<DOMRefValue<HTMLDivElement>>> = | |||
There was a problem hiding this comment.
yeah.... it's awful
# Conflicts: # packages/@react-spectrum/s2/src/Tabs.tsx
# Conflicts: # packages/@react-spectrum/s2/src/Slider.tsx
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:TreeView-TreeView {
+TreeView <T extends {}> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children?: ReactNode | (T) => ReactNode
defaultExpandedKeys?: Iterable<Key>
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledBehavior?: DisabledBehavior = 'all'
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
expandedKeys?: Iterable<Key>
id?: string
isDetached?: boolean
isEmphasized?: boolean
items?: Iterable<T>
onAction?: (Key) => void
onExpandedChange?: (Set<Key>) => any
onSelectionChange?: (Selection) => void
renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldSelectOnPressUp?: boolean
slot?: string | null
styles?: StylesPropWithHeight
}/@react-spectrum/s2:TreeViewProps-TreeViewProps {
+TreeViewProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children?: ReactNode | (T) => ReactNode
defaultExpandedKeys?: Iterable<Key>
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledBehavior?: DisabledBehavior = 'all'
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
expandedKeys?: Iterable<Key>
id?: string
isDetached?: boolean
isEmphasized?: boolean
items?: Iterable<T>
onAction?: (Key) => void
onExpandedChange?: (Set<Key>) => any
onSelectionChange?: (Selection) => void
renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldSelectOnPressUp?: boolean
slot?: string | null
styles?: StylesPropWithHeight
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Same test instructions as #8375
Types should match https://app.unpkg.com/@react-spectrum/[email protected]/files/dist/types.d.ts
Note, I was more thorough on our S2 stories than I was with v3 because it's our documentation and it was easier to align them since they were already fairly close. I'd recommend writing all future stories in this style.
I found a handful of type errors in our stories as a result. I've corrected those. No changes to the source types :)
I think we may still be missing a generic on TreeView? @LFDanLu please have a look at the changes I made in the stories around
TreeExampleDynamic.ran chromatic https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=969 only changes are expected because I fixed some types
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: