feat: use new config model #357
Conversation
|
This PR will trigger a minor release when merged. |
| @@ -53,7 +51,7 @@ async function getSitesToAudit(dataAccess, url, deliveryType, orgs) { | |||
| const site = await dataAccess.getSiteByBaseURL(url); | |||
| sitesToAudit = site ? [site] : []; | |||
| } | |||
| return sitesToAudit.filter((site) => !isAuditsDisabled(site, orgs[site.getOrganizationId()])); | |||
| return sitesToAudit; | |||
There was a problem hiding this comment.
The js doc needs to be updated, because in the new version we don't have a flag to disable all handler types for a site.
| alerts: | ||
| - type: '404' | ||
| byOrg: true | ||
| handlers: |
There was a problem hiding this comment.
We can start reusing examples, when they become repetitive: https://swagger.io/docs/specification/adding-examples/ -> Reusing Examples
docs/openapi/schemas.yaml
Outdated
| description: The Slack mentions to include in the alert | ||
| $ref: '#/SlackMentionConfig' | ||
| excludedURLs: | ||
| description: URLs to be excluded from the alert |
There was a problem hiding this comment.
nitpicking: URLs to be excluded from the handler's processing?
There was a problem hiding this comment.
Would manualOverwrites, fixedURLs from broken-backlinks need to be added here as well or would they be allowed under broken-backlinks key?
There was a problem hiding this comment.
I will add them as well
There was a problem hiding this comment.
@alinarublea would this cover the manualOverwrites doc from #387 ? Or can I update the PR after this one is merged?
There was a problem hiding this comment.
Yes, it s exactly that, I wont modify it then and I will let you know after I merge
|
🎉 This issue has been resolved in version 1.56.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
Related Issues
Thanks for contributing!