-
Notifications
You must be signed in to change notification settings - Fork 201
fix(azure-preview-workflow): update resource url to remove + use same token pattern #3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectrum-two
Are you sure you want to change the base?
fix(azure-preview-workflow): update resource url to remove + use same token pattern #3979
Conversation
|
📚 Branch previewPR #3979 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3979/index.html. |
File metricsSummaryTotal size: 1.42 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR fixes the issue you were seeing. I do have one "let's check on this" thing: can you take a peek at Tarun's PR over in SWC and specifically the comments about passing some of these tokens around? I might be being overly cautious or paranoid, but if you could at least check on if these could be exposed/used in a risky way, that'd be appreciated!
Updated in f703a86. Going to look at retrieving the new credentials in the AM. ✨ |
f703a86
to
102c2d7
Compare
Description
Verified: closed this PR, checked Azure admin and clean up succeeded. Pertinent run: https://github.com/adobe/spectrum-css/actions/runs/15788421553/job/44509686573
To-do list