Skip to content

fix(azure-preview-workflow): update resource url to remove + use same token pattern #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: spectrum-two
Choose a base branch
from

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Jun 20, 2025

Description

Verified: closed this PR, checked Azure admin and clean up succeeded. Pertinent run: https://github.com/adobe/spectrum-css/actions/runs/15788421553/job/44509686573

  • Fixes failing removal portion of job by correcting URL param for remove command.
  • Carries over logic from deploy step to clean and apply token when running remove command.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf requested review from pfulton and castastrophe June 20, 2025 21:43
@cdransf cdransf self-assigned this Jun 20, 2025
@cdransf cdransf added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Jun 20, 2025
Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: 102c2d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf cdransf changed the base branch from main to spectrum-two June 20, 2025 21:43
Copy link
Contributor

github-actions bot commented Jun 20, 2025

📚 Branch preview

PR #3979 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3979/index.html.

@cdransf cdransf closed this Jun 20, 2025
@cdransf cdransf reopened this Jun 20, 2025
Copy link
Contributor

github-actions bot commented Jun 20, 2025

File metrics

Summary

Total size: 1.42 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR fixes the issue you were seeing. I do have one "let's check on this" thing: can you take a peek at Tarun's PR over in SWC and specifically the comments about passing some of these tokens around? I might be being overly cautious or paranoid, but if you could at least check on if these could be exposed/used in a risky way, that'd be appreciated!

@cdransf
Copy link
Member Author

cdransf commented Jun 24, 2025

I think this PR fixes the issue you were seeing. I do have one "let's check on this" thing: can you take a peek at Tarun's PR over in SWC and specifically the comments about passing some of these tokens around? I might be being overly cautious or paranoid, but if you could at least check on if these could be exposed/used in a risky way, that'd be appreciated!

Updated in f703a86. Going to look at retrieving the new credentials in the AM. ✨

@cdransf cdransf force-pushed the cdransf/azure-workflow-blob-storage-remove-fix branch from f703a86 to 102c2d7 Compare June 24, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants