Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failing in FastBoot #31

Conversation

zeppelin
Copy link

@zeppelin zeppelin commented Jan 1, 2018

Follow-up to #24. This PR doesn't provide FastBoot compatibility, it merely prevents the content of the initializer to run, because the container that's required to access the service is not present in initializers. This means that assets being requested from the service in FastBoot are not correct, but at least the app won't fail to serve requests.

@RuslanZavacky
Copy link
Contributor

I actually think this addon should work with Fastboot, I'll try to look what is causing its failure.

@zeppelin
Copy link
Author

Closing in favor of #33

@mydea 👏

@zeppelin zeppelin closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants