fix: propagating lifecycle events to AndroidScreenLifecycleOwner #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syer10
reviewed
Oct 16, 2023
| if (activity != null && activity is LifecycleOwner) { | ||
| private fun registerLifecycleListenerForSaveState(outState: Bundle) { | ||
| val lifecycleOwner = getParentLifecycleOwnerOrActivityOrNull() | ||
| if (lifecycleOwner != null) { | ||
| val observer = object : DefaultLifecycleObserver { | ||
| override fun onStop(owner: LifecycleOwner) { | ||
| performSave(outState) |
There was a problem hiding this comment.
This can be moved to the proper lifecycle listener
| * Returns a unregister callback | ||
| */ | ||
| private fun registerLifecycleListenerPropagation(): () -> Unit { | ||
| val lifecycleOwner = getParentLifecycleOwnerOrActivityOrNull() |
There was a problem hiding this comment.
Why are we doing this instead of just using atomicParentLifecycleOwner?
|
Did some cleanup and some documentation @Syer10 |
Syer10
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #225
fixes #186
fixes #173