Fix: BottomSheet closes when recomposing in iOS #330 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also report this on Compose Multiplatform Issues ? |
|
Hi @DevSrSouza I think this one is related |
|
Also this one |
|
Thank you for this PR! I just saw this issue myself. Plz cut a new alpha release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue details:
#330
Affected Platform: iOS
Compose version: 1.6.0
It seems the culprit is
confirmValueChangeinrememberModalBottomSheetState, it's usingrememberSaveablewhereconfirmValueChangeis used as a key. When this method changes in iOS somehow when you open keyboard or any other thing that causes recomposition, it recreates the sheet state, which hides the bottom sheet modal.Removing
confirmValueChangeand usingLaunchedEffectto observesheetState.currentValuesolves the issue.