update screen transition #428
Conversation
| @Composable | ||
| public fun ScreenTransition( | ||
| navigator: Navigator, | ||
| screenTransition: ScreenTransition, |
There was a problem hiding this comment.
practice has shown that it is convenient to get a default transition as ScreenTransition argument here
|
|
||
| import cafe.adriel.voyager.transitions.ScreenTransition | ||
|
|
||
| data class NoCustomAnimationSampleScreen( |
There was a problem hiding this comment.
If we navigate to this screen, or pop from it, default animation will be used
| override val index: Int, | ||
| ) : BaseSampleScreen() | ||
|
|
||
| data class FadeAnimationSampleScreen( |
There was a problem hiding this comment.
If we navigate to this screen, or pop from it, fade animation will be used
shpasha
force-pushed
the
improve-screen-transition
branch
from
b9eb285 to
c4d22da
Compare
shpasha
force-pushed
the
improve-screen-transition
branch
from
c4d22da to
2a68388
Compare
voyager-transitions/src/commonMain/kotlin/cafe/adriel/voyager/transitions/ScreenTransition.kt
Show resolved
Hide resolved
| public fun enter(isPop: Boolean): EnterTransition? = null | ||
|
|
||
| /** | ||
| * Defines the exit transition for the Screen. | ||
| * | ||
| * Returns null when it should not define a transition for this screen. | ||
| */ | ||
| public fun exit(): ExitTransition? = null | ||
| public fun exit(isPop: Boolean): ExitTransition? = null |
There was a problem hiding this comment.
I still not 100% sure if isPop is enough, there are cases where other events maters for transition besides pop? if so, we could pass the navigation last event directly.
|
Can you also update the docs in the repo? We have moved to the repo |
shpasha
force-pushed
the
improve-screen-transition
branch
4 times, most recently
from
4b6530a to
683bd46
Compare
shpasha
force-pushed
the
improve-screen-transition
branch
from
683bd46 to
c195baf
Compare
|
@DevSrSouza If there are no more problems, maybe we can merge the request? |
|
@shpasha Can you update this docs @shpasha https://github.com/adrielcafe/voyager/blob/main/docs/transitions-api.md ? Adding the new ScreenTransition function and some examples using delegate implementation, etc. |
|
@DevSrSouza docs updated |
|
Awesome work, thanks for the contribution |
A slightly different approach to screen transitions. Now the active screen (the one we push) determines the animation. We already have this approach in our approach and it is very convenient.
I also added lastEvent to the enter/exit to understand the slide direction
sample.webm