Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace all atomic snapshot operation #519

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: replace all atomic snapshot operation #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions voyager-core/src/commonMain/kotlin/cafe/adriel/voyager/core/stack/SnapshotStateStack.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import androidx.compose.runtime.saveable.Saver
import androidx.compose.runtime.saveable.listSaver
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.runtime.snapshots.Snapshot
import androidx.compose.runtime.snapshots.SnapshotStateList
import androidx.compose.runtime.toMutableStateList

Expand Down Expand Up @@ -111,15 +112,19 @@ public class SnapshotStateStack<Item>(
}

public override infix fun replaceAll(item: Item) {
stateStack.clear()
stateStack += item
lastEvent = StackEvent.Replace
Snapshot.withMutableSnapshot {
stateStack.clear()
stateStack += item
lastEvent = StackEvent.Replace
}
}

public override infix fun replaceAll(items: List<Item>) {
stateStack.clear()
stateStack += items
lastEvent = StackEvent.Replace
Snapshot.withMutableSnapshot {
stateStack.clear()
stateStack += items
lastEvent = StackEvent.Replace
}
}

public override fun pop(): Boolean =
Expand Down