-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli.py: encoding='utf-8' #696
base: master
Are you sure you want to change the base?
Conversation
Hello and thanks for the proposal. Could you check out other pull requests related to character encoding? How does this one differ from them? |
Hi @adrienverge, happy connecting. There are total 3 merge requests related to encoding. The https://github.com/adrienverge/yamllint/pull/630/files#diff-2e0288fc9fc3cda09f90a25f76bedb9ce0cea019d01147b436e575c71a3e674eR222 merge request looks fine but it doesn't have the change I applied. My problem is that I have Persian UTF8 text in my YAML files and the problem was related to the 'cli.py' file. Related to my issue https://github.com/adrienverge/yamllint/pull/240/files looks like a good patch as it can automatically detect the encoding and then use that in reading the file but I can see your comments there and it seems you are not happy to add new dependencies. Q: "I'm very against adding dependencies (like chardet)." |
Hello Max, thanks. It looks like #630 solves the same problem but is more complete and future-proof. Also, your PR doesn't fix encoding problems for other files such as configuration. What do you think?
In the meantime, a solution is to tell Python to read files as UTF-8 by default: export PYTHONUTF8=1
yamllint your-file.yaml |
Thank you @adrienverge, I added PYTHONUTF8 var to our @jbampton and I will do more testing. |
The issue happened in our project at SalamLang/Salam#265 in
pre-commit
for lining YAML files.