2024-12-01, Version 23.4.0 (Current), @aduh95 #19
+13,164
−20,810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.5. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.5) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: nodejs#55894 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#52888 Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#55883 Refs: nodejs#52104 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
The --shared-ada flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
The --shared-simdutf flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#55889 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854 PR-URL: nodejs#55890 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
This function does not require a CLI flag, does not emit a warning, and is a fairly simple API that is already being used heavily in the ecosystem. This commit marks context.plan() as stable. PR-URL: nodejs#55895 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This commit marks the test runner's snapshot testing API as stable. PR-URL: nodejs#55897 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Refs: nodejs/node-core-utils#835 PR-URL: nodejs#55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#55791 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: nodejs#55904 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: nodejs#42923 PR-URL: nodejs#55514 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: nodejs#55908 Fixes: NixOS/nixpkgs#355919 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#55857 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#55912 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#54678 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#55947 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#54213 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#55927 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: nodejs#55935 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#55923 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Refs: nodejs/security-wg#1236 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#55940 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#55928 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
As part of the standard experimental feature graduation policy, when we unflagged require(esm) we moved the experimental warning to be emitted when require() is actually used to load ESM, which previously was an error. However, some packages in the ecosystem have already being using try-catch to load require(esm) to e.g. resolve optional dependency, and emitting warning from there instead of throwing directly could break the CLI output. To reduce the disruption for releases, as a compromise, this patch skips the warning if require(esm) comes from node_modules, where users typically don't have much control over the code. This warning will be eventually removed when require(esm) becomes stable. This patch was originally intended for the LTS releases, though it seems there's appetite for it on v23.x as well so it's re-targeted to the main branch. PR-URL: nodejs#55960 Refs: nodejs#55217 Refs: nodejs#52697 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
PR-URL: nodejs#55946 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#54432 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs#55296 Reviewed-By: James M Snell <[email protected]>
Document the process for adding a message that ambassadors will be asked to promote. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#55843 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#55690 Refs: nodejs/security-wg#860 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: nodejs#50399 Co-Authored-By: Cristian Barlutiu <[email protected]> PR-URL: nodejs#54630 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jithil P Ponnan <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Signed-off-by: tchetwin <[email protected]> PR-URL: nodejs#55750 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#55951 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Fixes: nodejs#47200 Co-authored-by: Luigi Pinca <[email protected]> PR-URL: nodejs#55959 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
This commit removes some asynchronous logic from the runHook() method and replaces ArrayPrototypeReduce() with a for loop. PR-URL: nodejs#55963 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fixes: nodejs#52663 Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: nodejs#55714 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: nodejs#55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This commit refactors the chain of functions in run() to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: nodejs#55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token PR-URL: nodejs#55943 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: nodejs#55934 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#55786 Fixes: nodejs#55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: nodejs#55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#55892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
* separate stats and symbols into separate files * quic: rename `EndpointStats` and `SessionStats` to be consistent * s/EndpointStats/QuicEndpointStats/ * s/SessionStats/QuicSessionStats/ * separate state into separate files and other cleanups * extend tls options validations * rename classes for consistency and other cleanups PR-URL: nodejs#55971 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs#55973 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#55975 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#55977 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Http2Session should always call ondone into JS to detach the handle. In some case, ondone is defered to be called by the StreamListener through WriteWrap, we should be careful of this before getting rid of the StreamListener. PR-URL: nodejs#55966 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: nodejs#55967 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Refs: nodejs/build#3963 PR-URL: nodejs#55930 Refs: nodejs#53863 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: nodejs#55925 PR-URL: nodejs#55982 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-12-01, Version 23.4.0 (Current), @aduh95
Notable Changes
a4f57f0293] - (SEMVER-MINOR) assert: add partialDeepStrictEqual (Giovanni Bucci) #54630efb9f05f59] - (SEMVER-MINOR) doc,lib,src,test: unflag sqlite module (Colin Ihrig) #55890d777d4a52d] - (SEMVER-MINOR) sqlite: addStatementSync.prototype.iteratemethod (tpoisseau) #54213Commits
5b0ce376a2] - assert: optimize partial comparison of twoSets (Antoine du Hamel) #55970a4f57f0293] - (SEMVER-MINOR) assert: add partialDeepStrictEqual (Giovanni Bucci) #546307133c0459f] - build: avoid compiling with VS v17.12 (Stefan Stojanovic) #55930ce53f1689f] - build: set node_arch to target_cpu in GN (Shelley Vohr) #559672023b09d27] - build: add create release proposal action (Rafael Gonzaga) #5569026ec99634c] - build: use variable for crypto dep path (Shelley Vohr) #55928f48e289580] - build: fix GN build for sqlite (Cheng) #55912fffabca6b8] - build: compile bundled simdutf conditionally (Jakub Jirutka) #55886d8eb83c5c5] - build: compile bundled simdjson conditionally (Jakub Jirutka) #5588683e02dc482] - build: compile bundled ada conditionally (Jakub Jirutka) #5588693d36bf1c8] - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits (Filip Skokan) #55296f99f95f62f] - deps: update corepack to 0.30.0 (Node.js GitHub Bot) #5597796e846de89] - deps: update ngtcp2 to 1.9.0 (Node.js GitHub Bot) #55975d180a8aedb] - deps: update simdutf to 5.6.3 (Node.js GitHub Bot) #55973288416a764] - deps: upgrade npm to 10.9.1 (npm team) #55951cf3f7ac512] - deps: update zlib to 1.3.0.1-motley-7e2e4d7 (Node.js GitHub Bot) #544327768b3d054] - deps: update simdjson to 3.10.1 (Node.js GitHub Bot) #546789c6103833b] - deps: update simdutf to 5.6.2 (Node.js GitHub Bot) #55889baed2763df] - doc: deprecate passing invalid types infs.existsSync(Carlos Espa) #55892a3f7db6b6d] - doc: add doc for PerformanceObserver.takeRecords() (skyclouds2001) #55786770572423b] - doc: add vetted courses to the ambassador benefits (Matteo Collina) #5593498f8f4a8a9] - doc: ordernode:cryptoAPIs alphabetically (Julian Gassner) #558311e0decb44c] - doc: doc how to add message for promotion (Michael Dawson) #55843ff48c29724] - doc: add esm example for zlib (Leonardo Peixoto) #55946ccc5a6d552] - doc: document approach for building wasm in deps (Michael Dawson) #55940c8bb8a6ac5] - doc: fix Node.js 23 column in CHANGELOG.md (Richard Lau) #559359d078802ad] - doc: remove RedYetiDev from triagers team (Aviv Keller) #559475a2a757119] - doc: add esm examples to node:timers (Alfredo González) #55857f711a48e15] - doc: fix relative path mention in --allow-fs (Rafael Gonzaga) #55791219f5f2627] - doc: include git node release --promote to steps (Rafael Gonzaga) #55835f9d25ed3e4] - doc: add history entry for import assertion removal (Antoine du Hamel) #55883efb9f05f59] - (SEMVER-MINOR) doc,lib,src,test: unflag sqlite module (Colin Ihrig) #558909289374248] - http2: fix memory leak caused by premature listener removing (ywave620) #5596630f26ba254] - lib: avoid excluding symlinks in recursive fs.readdir with filetypes (Juan José) #557144be5047030] - module: do not warn when require(esm) comes from node_modules (Joyee Cheung) #559601fb30d6e86] - quic: multiple updates to quic impl (James M Snell) #55971d777d4a52d] - (SEMVER-MINOR) sqlite: addStatementSync.prototype.iteratemethod (tpoisseau) #54213971f5f54df] - src: safely remove the last line from dotenv (Shima Ryuhei) #55982497a9aea1c] - src: fix kill signal on Windows (Hüseyin Açacak) #55514f7567d46d8] - test: make HTTP/1.0 connection test more robust (Arne Keller) #55959c157e026fc] - test: convert readdir test to use test runner (Thomas Chetwin) #5575029362ce673] - test: make x509 crypto tests work with BoringSSL (Shelley Vohr) #55927493e16c852] - test: fix determining lower priority (Livia Medeiros) #559087c3a4d4bcd] - test_runner: refactor Promise chain in run() (Colin Ihrig) #5595895e8c4ef6c] - test_runner: refactor build Promise in Suite() (Colin Ihrig) #55958c048865199] - test_runner: simplify hook running logic (Colin Ihrig) #559638197815fe8] - test_runner: mark snapshot testing as stable (Colin Ihrig) #558978a5d8c7669] - test_runner: mark context.plan() as stable (Colin Ihrig) #5589532b1681b7f] - tools: use tokenless Codecov uploads (Michaël Zasso) #55943475141e370] - tools: add linter for release commit proposals (Antoine du Hamel) #55923d093820f64] - tools: lint js indoc/**/*.md(Livia Medeiros) #5590472eb710f0f] - tools: fix riscv64 build failed (Lu Yahan) #52888882b70c83f] - tools: bump cross-spawn from 7.0.3 to 7.0.5 in /tools/eslint (dependabot[bot]) #55894