Fix CDS extractor findPackageJsonDirs
function
#194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
fixes a typo in a comment, as identified in a previous PR ( Begin multi-phase conversion of the CodeQL CDS extractor : Improve Modularity and Testing #188 );
updates the logic of the CDS extractor's
findPackageJsonDirs
function;fixes a regression in the CDS extractor ( as introduces in PR Begin multi-phase conversion of the CodeQL CDS extractor : Improve Modularity and Testing #188 ) where a "project directory" is not properly recognized when its path is the same as the "source root" directory for the CDS extractor scan;
adds unit tests to cover edge cases idendified for the
findPackageJsonDirs
function.