Skip to content

Fix CDS extractor findPackageJsonDirs function #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

data-douser
Copy link
Collaborator

This commit:

This commit:

- fixes a typo in a comment, as identified in a previous PR ( advanced-security#188 );

- updates the logic of the CDS extractor's `findPackageJsonDirs` function;

- fixes a regression in the CDS extractor where a "project directory"
  was not properly recognized when its path was the same as the
  "source root" directory for the CDS extractor scan;

- adds unit tests to cover edge cases idendified for the
  `findPackageJsonDirs` function.
@data-douser data-douser self-assigned this May 15, 2025
@data-douser data-douser marked this pull request as ready for review May 15, 2025 22:46
@lcartey lcartey merged commit 83bc1e4 into advanced-security:main May 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants