Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move prometheus metrics to unsealed portion of routes #246

Merged
merged 1 commit into from
Sep 16, 2019
Merged

move prometheus metrics to unsealed portion of routes #246

merged 1 commit into from
Sep 16, 2019

Conversation

simao
Copy link
Contributor

@simao simao commented Sep 16, 2019

No description provided.

@simao simao requested a review from alexhumphreys September 16, 2019 16:49
alexhumphreys
alexhumphreys approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@alexhumphreys alexhumphreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely don't know enough scala to comment on this, but it looks vaguely legit from what i remember a few years back.

@simao simao merged commit 5558b13 into master Sep 16, 2019
@simao simao deleted the fix-metrics-routes branch September 16, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhumphreys alexhumphreys alexhumphreys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simao @alexhumphreys