Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ota 3507/custom metadata overwritten #252

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Bugfix/ota 3507/custom metadata overwritten #252

merged 2 commits into from
Nov 7, 2019

Conversation

jochenschneider
Copy link
Contributor

Added field to TargetCustom which tracks proprietary attributes.

Jochen Schneider added 2 commits November 6, 2019 10:52
Reproduction/test
f6f4cca 
Signed-off-by: Jochen Schneider <[email protected]>
Lossless TargetCustom codec
50a3aab 
Signed-off-by: Jochen Schneider <[email protected]>
@jochenschneider jochenschneider requested a review from simao November 6, 2019 10:26
simao
simao approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@simao simao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm.
I would like to have logic out of the decoders as I find that they can get complicated quite quickly and really business logic should not be on the decoders, but I think this is quite a neat solution to fix the bug.

@jochenschneider
Copy link
Contributor Author

Yeah ideally there would be deriveLosslessDecoder[TargetCustom]('proprietary), but I don't know if that is possible.

@jochenschneider jochenschneider merged commit f6013d6 into master Nov 7, 2019
@jochenschneider jochenschneider deleted the bugfix/OTA-3507/custom-metadata-overwritten branch November 7, 2019 13:48
@tkfu tkfu mentioned this pull request Nov 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simao simao simao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenschneider @simao