Return expired root.json if keys are offline #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, a user cannot `garage-sign root pull` as keyserver always returns an error since it tries to refresh the role, but the keys to do so are offline. With this change the expired root.json is returned and is up to the client to validate it according to the tuf/update spec. I don't like that I am quite explicitly using an exception for control flow, but the other alternative would be to return a `Future[ResultType]`, and then have a dedicated `ResultType` for this, but I think it's too complex to use something like that. Signed-off-by: Simão Mata <[email protected]>
|
Ah that fixes the issue Raigi was having? |
jochenschneider
approved these changes
Jan 23, 2020
|
Yes, hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, a user cannot
garage-sign root pullaskeyserver always returns an error since it tries to refresh the role,
but the keys to do so are offline.
With this change the expired root.json is returned and is up to the
client to validate it according to the tuf/update spec.
I don't like that I am quite explicitly using an exception for control
flow, but the other alternative would be to return a
Future[ResultType], and then have a dedicatedResultTypefor this,but I think it's too complex to use something like that.
Signed-off-by: Simão Mata [email protected]