Support multiple reloads in a pipeline; helps #41 #70
Conversation
|
This looks really useful! Any plans to get it merged? |
|
To the extent that it might be useful to anyone even without having been merged, you can use the following dependency to test it out: |
|
Hmm, I guess we could merge this. I have other plans to eventually fix #41 without need for users to set any options etc. But I guess we can add the option for now and remove it when I finally have time to look into refactoring the implementation. |
|
@samroberton Could you rebase this against the latest commit? |
This commit does two things: 1. Use a gensym'd name for the (former) `adzerk.boot_reload` ns, so that different `reload` tasks in a single pipeline can operate independently without collisions. 2. Introduce an optional `:only-by-re` option, and when it's set, only send reloads of files in the fileset which match the given patterns. This presents a solution to the problem in adzerk-oss#41, in that reloads can be limited to the artefacts from a single build's compilation artefacts, avoiding the need for the `reload` task to do dependency tracking. For example: (deftask dev [] (comp (watch) (reload :ids #{"react-www"} :only-by-re [#"^react-www\.out/.*"] :on-jsload 'my.react-www.app/reload) (reload :ids #{"react-native"} :only-by-re [#"^react-native\.out/.*"] :on-jsload 'my.react-native.app/reload) (cljs :ids #{"react-www" "react-native"} :optimizations :none)))
samroberton
force-pushed
the
multiple-reloads
branch
from
52db0a3 to
8d476fb
Compare
|
No problems: I've just pushed a rebased commit (which I've also put up on Clojars as |
This commit does two things:
adzerk.boot_reloadns, so thatdifferent
reloadtasks in a single pipeline can operate independentlywithout collisions.
:only-by-reoption, and when it's set, onlysend reloads of files in the fileset which match the given patterns.
This presents a solution to the problem in Reload only a build's dependencies #41, in that reloads can be
limited to the artefacts from a single build's compilation artefacts,
avoiding the need for the
reloadtask to do dependency tracking.For example: