-
Notifications
You must be signed in to change notification settings - Fork 208
[ENH] add a difference transformer to series transformations #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add a difference transformer to series transformations #2729
Conversation
Thank you for contributing to
|
It seems that one of the automated checks failed with errors indicating it couldn't find the merge base or my commit SHA:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, few comments.
I have made som modifications according to your comments. @MatthewMiddlehurst |
@MatthewMiddlehurst I am wondering if you could give it a quick look when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the most part, just one documentation bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
* feat: add new tags information for anomaly detection * feat: add tag information in given anomaly modles * fix: add new anomaly detector tags in mock anomaly detector class * fix: use anomaly-detector instead of estimator for new tags * update and add basic testing * fixes --------- Co-authored-by: MatthewMiddlehurst <[email protected]>
…timator (aeon-toolkit#2612) * Added the docs for base series and base classes * Updated documentation for base classes --------- Co-authored-by: Matthew Middlehurst <[email protected]>
* output type added * hydra wflow modified * hydra test file added * pr_pytest reverted * soft dep check added * soft dep corrected * docstring corrected, enhanced test cases
* Improved Hidalgo Segmentation Notebook * Updated hidalgo notebook --------- Co-authored-by: Matthew Middlehurst <[email protected]>
Co-authored-by: TonyBagnall <[email protected]>
…lkit#2821) Bumps the github-actions group with 1 update: [crs-k/stale-branches](https://github.com/crs-k/stale-branches). Updates `crs-k/stale-branches` from 7.0.1 to 8.1.1 - [Release notes](https://github.com/crs-k/stale-branches/releases) - [Commits](crs-k/stale-branches@v7.0.1...v8.1.1) --- updated-dependencies: - dependency-name: crs-k/stale-branches dependency-version: 8.1.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added test cases for feature based clustering * Automatic `pre-commit` fixes * added docstring * Automatic `pre-commit` fixes * added . * added . * updated tsfresh * Automatic `pre-commit` fixes * added pytest _check_soft_dependencies for tsfresh * Automatic `pre-commit` fixes * added more testing * Automatic `pre-commit` fixes * added docs * added docs * added pytest * Automatic `pre-commit` fixes * improved docs * Automatic `pre-commit` fixes * improved test cases * changes made as requested by moderators * changes made as requested by moderators * Automatic `pre-commit` fixes * changed "percentiles" to "quantiles" --------- Co-authored-by: Ramana-Raja <[email protected]> Co-authored-by: Matthew Middlehurst <[email protected]> Co-authored-by: Tony Bagnall <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Reference Issues/PRs
fixes #1553
What does this implement/fix? Explain your changes.
This implements a transformer that computes the n-order differences of a time series.
The input time series is expected to have a NumPy inner-type, and the transformation is performed using numpy.diff().
To preserve the original shape of the series along the time axis, the first order element(s) of the output are filled with NaN.
Does your contribution introduce a new dependency? If yes, which one?
No. It only depends on NumPy.
Any other comments?
No.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access