Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement decoding of channel state #1737

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jan 24, 2023

depends on #1736
related to #1619
found issues aeternity/protocol#505 aeternity/protocol#506 aeternity/protocol#507 aeternity/protocol#508

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added this to the v13 milestone Jan 24, 2023
@davidyuk davidyuk force-pushed the feature/decode-channel-state branch from c13e7f4 to 826d039 Compare January 24, 2023 08:33
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@72d0cd5). Click here to learn what that means.
Patch coverage: 78.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1737   +/-   ##
==========================================
  Coverage           ?   82.39%           
==========================================
  Files              ?       87           
  Lines              ?     2987           
  Branches           ?      577           
==========================================
  Hits               ?     2461           
  Misses             ?      247           
  Partials           ?      279           
Impacted Files Coverage Δ
src/tx/builder/field-types/array.ts 100.00% <ø> (ø)
src/tx/builder/field-types/entry.ts 91.66% <ø> (ø)
src/tx/builder/field-types/mptree.ts 80.80% <ø> (ø)
src/channel/Contract.ts 79.45% <50.00%> (ø)
src/tx/builder/field-types/short-u-int-const.ts 66.66% <50.00%> (ø)
src/tx/validator.ts 85.43% <57.14%> (ø)
src/channel/Base.ts 76.59% <66.66%> (ø)
src/tx/builder/field-types/fee.ts 91.48% <66.66%> (ø)
src/tx/builder/field-types/wrapped.ts 66.66% <66.66%> (ø)
src/tx/builder/index.ts 90.00% <83.33%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidyuk davidyuk force-pushed the feature/decode-channel-state branch from 826d039 to af6fa50 Compare January 24, 2023 08:49
@davidyuk davidyuk force-pushed the feature/decode-channel-state branch from af6fa50 to ed31aff Compare January 25, 2023 08:24
@davidyuk davidyuk merged commit 27314fb into develop Jan 25, 2023
@davidyuk davidyuk deleted the feature/decode-channel-state branch January 25, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant