-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depr: deprecate utils.downloads
in favor of Dataset.download()
#1030
Open
dkrako
wants to merge
18
commits into
main
Choose a base branch
from
depr/utils-downloads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 82 +4
Lines 3561 3618 +57
Branches 629 645 +16
=========================================
+ Hits 3561 3618 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.downloads
is deprecated. please useDataset.downloads()
instead.utils.downloads
will be removed in pymovements v0.26.0Description
Deprecate
utils.downloads
in favor ofDataset.downloads()
The following warnings are printed:
partly resolves #999
blocked by #1028
Implemented changes
utils/downloads.py
todataset/_utils/downloads.py
and adjusted to new locationdataset._utils.downloads
indataset.dataset_download
utils/downloads.py
tests/unit/utils/downloads_test.py
totests/unit/dataset/_utils/_downloads_test.py