Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr: deprecate utils.strings #1031

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

depr: deprecate utils.strings #1031

wants to merge 4 commits into from

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Mar 13, 2025

⚠️ Deprecation

utils.strings is deprecated and will be removed in pymovements v0.26.0

Description

Deprecate utils.strings as none of the included are intended for the end-user.

The following warning is printed:

DeprecationWarning: Call to deprecated function (or staticmethod) curly_to_regex. (This module will be removed in v0.26.0.) -- Deprecated since version v0.21.0.

partly resolves #999

Implemented changes

  • moved utils/strings.py to _utils/_strings.py and adjusted to new location
  • use _utils.strings in remaining source
  • created deprecated function in utils/strings.py
  • moved tests/unit/utils/strings_test.py to tests/unit/_utils/_strings_test.py
  • add test that functions are correctly deprecated
  • add test that functions are removed in planned version

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (87487d0) to head (bc23f86).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1031   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        80    +1     
  Lines         3588      3595    +7     
  Branches       645       645           
=========================================
+ Hits          3588      3595    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkrako dkrako enabled auto-merge (squash) March 13, 2025 16:15
Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR, just some minor questions/feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate utils modules that are not intended for end-users
2 participants