Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Register for LLM is not registering the function in the agent's function map #834

Closed
marklysze opened this issue Feb 5, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@marklysze
Copy link
Collaborator

Describe the bug

When trying a swarm with a ConversableAgent-based agent that had Tools associated with it that were registered for llm, the swarm failed because it was setting up the internal tool executor to execute all tools associated with all agents. The reason is because the tools were in the agent's tools but not their _function_map.

I noticed that when we run _register_for_llm we do not call register_function that puts these functions in an agent's function map.

_register_for_execution does call it.

Steps to reproduce

No response

Model Used

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

@marklysze marklysze added the bug Something isn't working label Feb 5, 2025
@marklysze marklysze added this to ag2 Feb 5, 2025
@marklysze marklysze self-assigned this Feb 5, 2025
@marklysze
Copy link
Collaborator Author

Closing this as though a minor fix was applied, the issue raised expects that functions are registered in the function_map if they are just for LLM recommendation, and this is not the case.

@github-project-automation github-project-automation bot moved this to Done in ag2 Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant