Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix]: Fix tool registration from a Tool #835

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Feb 5, 2025

Why are these changes needed?

There's a bug with tools and swarm function registration: Tool does not support __name__ but it has _name, so updated ConversableAgent._add_single_function to cater for this.

Related issue number

N/A

Checks

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 0 Missing and 1 partial ⚠️
Flag Coverage Δ
3.10 58.59% <0.00%> (+2.70%) ⬆️
3.11 30.79% <0.00%> (?)
3.12 27.61% <0.00%> (?)
3.13 42.51% <0.00%> (+7.86%) ⬆️
3.9 55.38% <0.00%> (+21.65%) ⬆️
anthropic 37.32% <0.00%> (?)
autobuild 17.59% <0.00%> (?)
bedrock 16.73% <0.00%> (?)
browser_use 29.40% <0.00%> (-0.01%) ⬇️
cerebras 16.45% <0.00%> (?)
cohere 16.49% <0.00%> (?)
crawl4ai 29.61% <0.00%> (-0.01%) ⬇️
deepseek 32.44% <0.00%> (?)
docs 28.59% <0.00%> (-0.01%) ⬇️
gemini 39.29% <0.00%> (?)
graph-rag-falkor-db 28.03% <0.00%> (-0.01%) ⬇️
groq 16.47% <0.00%> (?)
interop 29.47% <0.00%> (-0.01%) ⬇️
jupyter-executor 30.72% <0.00%> (-0.01%) ⬇️
lmm 19.80% <0.00%> (?)
long-context 15.61% <0.00%> (?)
macos-latest 58.94% <0.00%> (+2.62%) ⬆️
mistral 16.17% <0.00%> (?)
ollama 16.85% <0.00%> (?)
openai 45.10% <0.00%> (?)
retrievechat 29.58% <0.00%> (+0.04%) ⬆️
retrievechat-mongodb 29.57% <0.00%> (+1.26%) ⬆️
retrievechat-pgvector 29.57% <0.00%> (+1.26%) ⬆️
retrievechat-qdrant 29.52% <0.00%> (+1.28%) ⬆️
teachable 18.74% <0.00%> (?)
together 16.50% <0.00%> (?)
twilio 28.24% <0.00%> (-0.01%) ⬇️
ubuntu-latest 66.61% <0.00%> (+10.31%) ⬆️
websurfer 18.71% <0.00%> (?)
windows-latest 56.63% <0.00%> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 77.53% <0.00%> (+12.71%) ⬆️

... and 28 files with indirect coverage changes

@marklysze marklysze marked this pull request as draft February 5, 2025 22:38
@marklysze marklysze changed the title [Bug fix]: register_for_llm add to function map and tool fix [Bug fix]: Fix tool registration from a Tool Feb 5, 2025
@marklysze marklysze marked this pull request as ready for review February 5, 2025 23:19
@marklysze marklysze merged commit 84cf10d into main Feb 6, 2025
314 of 315 checks passed
@marklysze marklysze deleted the registerforllmwithfuncmap branch February 6, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant