Add --consecutive option #70
Conversation
Resolves agda#68 Add an option to check for maximum count of consecutive empty lines. If zero, unlimited cmount is allowed. If 1, there cannot be empty lines, if 2 there can be one empty line, and so on. I fail with naming, having value 1 to disallow any empty lines makes sense, but it's not "maximum amount of empty lines", it's more of "fail if there is that much empty lines".
phadej
force-pushed
the
consecutive-empty-lines
branch
from
fc06231 to
a7bf22a
Compare
|
Correction, I can be changed either way. |
This looks better to me than the first idea.
Why not |
There was a problem hiding this comment.
I think this is a useful addition.
Not allowing any empty line is maybe not a feature sought after in the context of fix-whitespace, so I think having 0 switching off the check (and 1 for normalizing subsequent empty lines to a single one) is ok.
So, happy to merge if that one comment is addressed.
|
Please suggest concrete changes, my English is quite bad (I feel i'm very often misunderstood), so instead of going back and forth on comments and wording, just propose what to write. If you cannot, I cannot either. |
|
Please pick all the colors for the bikeshed at once if you can; or I'll just ask ChatGPT to make the changes for you. |
|
I don't want to derail this already perfectly useful patch, so I'll try to stay away. Also just FYI I don't have the approve bits. |
Co-authored-by: Artem Pelenitsyn <[email protected]>
|
ping. I think I addressed the comment already. Please merge. |
|
gentle ping |
|
Ah, sorry, I was planning to get to this after #71 which I started to look at this weekend. My bikeshedding would have been confined to suggest another name for |
|
I like gap! |
Resolves #68
Add an option to check for maximum count of consecutive empty lines. If zero, unlimited cmount is allowed. If 1, there cannot be empty lines (1 empty lines triggers an error) , if 2 there can be one empty line (2 consecutive empty lines trigger an error), and so on.
I fail with naming, having value 1 to disallow any empty lines makes sense, but it's not "maximum amount of empty lines", it's more of "fail if there is that much empty lines".